Move machine type to Q35. #696
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This requires NUMA, which is OK - unless we are using a single vCPU. We could add NUMA awareness to a single CPU as well, will probably make life easier. |
I think it's time, and it'll enable us to add PCIE support. Later, hopefully we'll be able to do device-passthrough. I've added the following devices, which will be later used: pcie-root dmi-to-pci-bridge pci-bridge pcie-expander-bus I've also took the opportunity to get rid of the video device. It's not needed. Lastly, I've explicitly disabled the PM S3 and S4 functions. I kinda remember we've had them turned off, but anyway, added explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's time, and it'll enable us to add PCIE support.
Later, hopefully we'll be able to do device-passthrough.
I've also took the opportunity to get rid of the video device.
It's not needed.