Merged
Conversation
🦋 Changeset detectedLatest commit: 80be4a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 50 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
PeterSP
force-pushed
the
PLAT-530-preregister-kafka-health
branch
from
62e2394 to
c87ac7e
Compare
PeterSP
commented
May 26, 2022
| "preinstall": "npx check-node-version --package && npx only-allow pnpm && pnpm i -g pnpm@6.32.11", | ||
| "lint": "pnpm lint:audit && pnpm lint:prettier '**/package.json' && pnpm lint:markdown && pnpm lint:eslint '**/*.ts'", | ||
| "lint:audit": "pnpm-ci audit --strict -i GHSA-fwr7-v2mv-hh25", | ||
| "lint:audit": "pnpm-ci audit --strict -i GHSA-fwr7-v2mv-hh25 GHSA-wm7h-9275-46v2", |
Author
There was a problem hiding this comment.
We can undo this once expressjs/multer#1097 is merged.
avatarneil
reviewed
May 26, 2022
mdurling
approved these changes
May 27, 2022
mdurling
left a comment
mdurling
left a comment
There was a problem hiding this comment.
Minor nit re delete usage, but LGTM.
| await Promise.all(asArray(topics).map(topic => consumer.subscribe({ topic, fromBeginning }))) | ||
|
|
||
| registerLivelinessHandling(consumer, healthStatus) | ||
| delete healthStatus.components[preConnectComponentId] |
There was a problem hiding this comment.
I don't love using delete (I generally try to avoid), but the alternatives are somewhat cumbersome.
Author
There was a problem hiding this comment.
It didn't seem worth doing another destructure and assignment when the delete would suffice
nessur
approved these changes
May 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Purpose
Register Kafka Health-Check components immediately, prior to successful connection.
👌 Resolves:
📦 Impacts:
[long list TBD]
✅ PR Checklist