-
Notifications
You must be signed in to change notification settings - Fork 12
Nfr #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
svuillaume
wants to merge
15
commits into
lacework:main
Choose a base branch
from
svuillaume:nfr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Nfr #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ities - Fix groupby aggregation in fixable_vulns() that produced numpy arrays instead of scalar values, causing TypeError on subsequent groupby - Improve logging in get_host_vulns() to show record counts per page and total records retrieved for better debugging Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The 25-hour default window was too short for many Lacework accounts where vulnerability evaluations occur less frequently, resulting in empty vulnerability reports. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Major improvements to the report template: - Modern color-coded severity system (Critical/High/Medium/Low) - Card-based layout with visual hierarchy - "Immediate Actions Required" section with prioritized items - Remediation steps for each finding type - Severity badges and info boxes for quick identification - Table of contents with anchor navigation - Value proposition cards highlighting FortiCNAPP benefits - Timed recommendations (Immediate/Short-term/Medium-term/Ongoing) - Print-optimized styles with proper page breaks - Professional header and footer styling Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.