Conversation
This will fix some confusion, and stop client-only installs from being broken now that `Thing` can be imported at top level. Closes #120
Barecheck - Code coverage reportTotal: 85.75%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
julianstirling
left a comment
There was a problem hiding this comment.
Yes please!
quickstart_example.sh and index.rst both need updating to not ask for [server] install. Otherwise this is ready to go.
I'm a little surprised that didn't cause the test of quickstart to fail. I guess |
|
Thanks for spotting it in the docs. That's updated now, and I have searched for |
julianstirling
left a comment
There was a problem hiding this comment.
Approved. Merge at will
julianstirling
left a comment
There was a problem hiding this comment.
Sorry, unapproved... search server] too!
|
Rather unhelpful comment there. I was just rushing to stop a merge... |
|
Sorry about that, and thanks for spotting it. I guess I have done a rather more comprehensive search and I believe I've removed any mention of the |
Currently, a labthings client can be installed with
pip install labthings_fastapiand the server is installed withpip install labthings_fastapi[server]. #121 makes it possible to importThingfrom the top level namespace, which will fail if we don't have the optionalserverdependencies.This PR makes the server dependencies non-optional. Doing so will fix some confusion, and stop client-only installs from being broken now that
Thingcan be imported at top level.In the future, we should have a separate PyPI package for the client code. I think this will be clearer for people using it, avoid confusion for people needing server functionality, and help organise the code better.
Closes #120