Make Labelle compatible with python-barcode v0.16 #137
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In python-barcode [1] v0.16.0, the API of the BaseWriter constructor was narrowed [2] so two of its callbacks can no longer be None (see issue labelle-org#123 [3].) Given we override the implementation that would use those callbacks anyway, pass dummy callbacks. This ensures compatibility with both pre-v0.16 and newer versions of python-barcode. Additionally, loosen one of the assertions where the upstream wording of an error message slightly changed. Fixes labelle-org#123. [1]: https://pypi.org/project/python-barcode/ [2]: WhyNotHugo/python-barcode@v0.15.1...v0.16.0#diff-01c9de34453d29913aa28bb39e4c847e2ecf95cf81b1264c2759090f870152c9 [3]: labelle-org#123 Reported-by: @blaisegarant
Contributor
|
Thanks @claui for tracking this down! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In python-barcode v0.16.0, the API of the BaseWriter constructor was narrowed so two of its callbacks can no longer be None (see issue #123.)
Given we override the implementation that would use those callbacks anyway, this PR passes dummy callbacks. This ensures compatibility with both pre-v0.16 and newer versions of python-barcode.
Additionally, loosen one of the assertions where the upstream wording of an error message slightly changed.
Fixes #123.
/cc @blaisegarant, @maresb