Colton's Fixes #76
Merged
Colton's Fixes #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation_functions.py-w9h5xn Add annotation function tests with full coverage
- Fix test_num_ga_fp by adding get_num_ground_atoms method to interpretation_fp.py - Fix test_reorder_clauses_fp by making test robust to trace ordering differences - Add comprehensive error reports for test failures with root cause analysis - Update error reports with implemented fixes and verification results
…nt does not exist (#74)
Test updates
Colton fixes
Merge Colton's branch into main repo
Dyuman fixes from Colton's branch with new tests fixed
….py for timesteps
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements "Colton's Fixes" which enhances the PyReason test infrastructure and fixes issues in the interpretation system. The changes include a comprehensive test suite reorganization, bug fixes in the fixed-point reasoning implementation, and improvements to query handling.
- Implements unified test runner with coverage aggregation and parallel execution capabilities
- Fixes critical bug in reset_rules() where annotation functions weren't being cleared
- Corrects query behavior to return consistent bounds for failed queries
Reviewed Changes
Copilot reviewed 43 out of 46 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/dont_disable_jit/test_world.py | New unit tests for World component functionality |
| tests/unit/dont_disable_jit/conftest.py | Stub configuration for JIT-enabled tests |
| tests/unit/disable_jit/interpretations/test_interpretation_init.py | Fixes test assertion by removing time check |
| tests/unit/disable_jit/interpretations/test_interpretation_common.py | Updates DummyBound class and test expectations |
| tests/unit/api_tests/*.py | Comprehensive API test suite covering validation, state management, settings, reasoning, and file operations |
| tests/functional/*.py | Adds FP version tests and marks slow tests appropriately |
| pyreason/scripts/interpretation/interpretation_fp.py | Fixes rule application logic and removes debug print statements |
| pyreason/scripts/interpretation/interpretation.py | Corrects query return values for consistency |
| pyreason/pyreason.py | Fixes annotation functions clearing in reset_rules() |
| run_tests.py | Unified test runner with parallel execution and coverage aggregation |
| test_config.json | Configuration for different test suites |
| Makefile | Convenient shortcuts for running tests |
| pytest.ini | Centralized pytest configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.