Skip to content

Conversation

@ColtonPayne
Copy link
Collaborator

@ColtonPayne ColtonPayne commented Sep 9, 2025

This PR:

  • Adds unit tests for intperation.py and interpretation_fp.py for 99% branch coverage
  • Adds tests (both functional and unit) to compare evaluations done with the numba JIT compiler against the pure python compilations
  • Moved existing tests to a functional test directory
  • Adds pre-commit hooks to run unit tests before each commit and functional/JIT comparison tests for each push
  • Adds contributors guide for new users

This reverts commit 84c89c8.
…re-python-consistency

test: ensure numba jit matches python
…re-python-consistency-qt0w9n

test: ensure numba jit matches python
…re-python-consistency-urffdi

test: ensure numba jit matches python
…h-coverage-in-_ground_rule

test: expand _ground_rule coverage
@ColtonPayne ColtonPayne changed the title Interpretation Tests and pipeline updates Interpretation tests and pipeline updates Sep 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive unit tests for the interpretation modules and updates the testing pipeline to ensure consistent behavior between JIT and pure Python implementations.

  • Adds unit tests for interpretation.py and interpretation_fp.py targeting 99% branch coverage
  • Introduces functional and unit tests to verify consistency between numba JIT and pure Python execution
  • Reorganizes test structure with dedicated functional test directory

Reviewed Changes

Copilot reviewed 22 out of 29 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/unit/dont_disable_jit/test_numba_consistency.py Tests JIT/Python consistency for core interpretation functions
tests/unit/disable_jit/test_annotation_functions.py Unit tests for annotation functions module
tests/unit/disable_jit/interpretations/ Comprehensive unit tests covering interpretation logic with high branch coverage
tests/functional/ Existing tests moved to functional directory with updated paths
contributing.md New contributor guide with setup and testing instructions
.pre-commit-config.yaml Pre-commit hooks for automated testing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dyumanaditya dyumanaditya merged commit 9adeb62 into lab-v2:main Sep 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants