[Issue #591] Fix fire danger levels for DeSoto Parish.#592
Merged
LouisFettet merged 1 commit intomainfrom Nov 7, 2025
Merged
Conversation
…y normalizing parish names from both fire weather data and TopoJSON. Ensure that all rendered parish names match official names. Signed-off-by: Louis Fettet <louis@pelicanstate.digital>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Coverage after merging louis/591/fix-fire-danger-for-desoto-parish into main will be
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Reports for have been deployed to Vercel: |
There was a problem hiding this comment.
Pull Request Overview
This PR improves the parish name matching logic in the fire danger map by introducing a normalization function to handle inconsistent naming conventions between the TopoJSON geographic data and the fire weather API data.
Key changes:
- Added a
normalizeParishNamefunction that removes periods and spaces, and converts to lowercase for consistent matching - Updated the parish matching logic to use normalized names from both datasets
- Renamed "De Soto" to "DeSoto" in the TopoJSON data
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
parishes.json |
Updated TopoJSON data with corrected parish name spelling (De Soto → DeSoto) |
+page.svelte |
Added name normalization function with documentation and updated parish matching logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #591
DeSoto Parish is named "Desoto" in the fire danger data and was named "De Soto" in the TopoJSON, which caused the data for the parish to not render on the map (since a match could not be made).
Additionally, LaSalle Parish was rendering as "La Salle".
Proposed changes
Screenshots
Before
After
Acceptance criteria validation
Other details
Alternate solutions
Ideally we would match the parishes based on a unique identifier, but continuing to match by name was the quicker solution here.
Possible drawbacks
N/A
Requested feedback
N/A