fix: populate packageName and vulnerabilityName in activity stream events#1848
Open
gauravshinde1729 wants to merge 1 commit intol3montree-dev:mainfrom
Open
Conversation
…ents Signed-off-by: gauravshinde1729 <shindegauravpict@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1818 — the activity stream was showing "System detected a vulnerability in ?" for all detected events instead of the actual
CVE name and package name.
Root Cause
ReadEventsByAssetIDAndAssetVersionNamein the controller was callingtransformer.ConvertVulnEventToDto(ved.VulnEvent)which takes the baseVulnEventmodel and has no access to the joined fields (component_purl,cve_id) that the repository query already fetches via LEFT JOINs.Changes
transformer/vulnevent_transformer.go— addedConvertVulnEventDetailToDtowhich maps all joined fields including
VulnerabilityName(fromCVEID),PackageName(fromComponentPurl) andURI. RefactoredConvertVulnEventsToDtosto delegate to it.controllers/vuln_event_controller.go— replacedConvertVulnEventToDto(ved.VulnEvent)withConvertVulnEventDetailToDto(ved)so joined fields are no longer discarded.
controllers/vuln_event_controller_test.go— added tests forReadEventsByAssetIDAndAssetVersionNamecovering the 500 error path andverifying
packageNameandvulnerabilityNameare correctly populated inthe response.
Testing
go test ./controllers/ -run TestReadEventsByAssetIDAndAssetVersionName -vOutput: