fix: correct spacing between risk value and package name in activity stream#691
Open
gauravshinde1729 wants to merge 1 commit intol3montree-dev:mainfrom
Open
Conversation
…stream Signed-off-by: gauravshinde1729 <shindegauravpict@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1818 (UI side) — two rendering issues in the activity stream for
detected dependency vulnerability events:
"in" was visually attached to the risk value with no space
(e.g. "with a risk of 1.51in [icon]") because the leading space
inside
{" in "}was being stripped by the browser's inline-flex rendering.Trailing space in
eventTypeMessagesfor the "detected" case wasbeing collapsed before the inline-flex element.
Changes
src/components/VulnEventItem.tsx— moved{" in "}outside theinline-flexspan into a fragment so it renders as a regular textnode with proper spacing.
src/utils/view.ts— removed the trailing" "from thedetectedcase in
eventTypeMessagessince spacing is now handled by the{" in "}text node in the component.Testing
System detected CVE-XXXX-XXXX with a risk of 7.5 in [ecosystem icon] package@versionResult: