Skip to content

Add vladisslav2011's EC hotpatch and battery fix deltas.#2

Open
jwise wants to merge 2 commits intol29ah:masterfrom
jwise:x210
Open

Add vladisslav2011's EC hotpatch and battery fix deltas.#2
jwise wants to merge 2 commits intol29ah:masterfrom
jwise:x210

Conversation

@jwise
Copy link
Copy Markdown

@jwise jwise commented Aug 29, 2020

I did an r2 bindiff on vladisslav2001's EC to port some of his fixes over to x2100. Here's the EC hotpatch delta, for use with his ec_sys.ko changes. Also enclosed is his battery bugfixes.

Note that I have NOT tested these changes, since I don't have an x210 board! So until someone tests this, use at your own risk. I've only tested my ported version on x2100.

@l29ah
Copy link
Copy Markdown
Owner

l29ah commented Aug 31, 2020

Are those changes just parts of his patchset or they are substantially different to accommodate for the X2100? If it's the latter, having a distinct option for X2100 mode or forking the project altogether may make more sense to avoid confused users bricking their laptops.

Anyway, i don't have a setup to unbrick my X210 in case of problems these days, so i'll wait until someone chimes in and tests it before merging.

@jwise
Copy link
Copy Markdown
Author

jwise commented Aug 31, 2020

These changes are parts of his patchset, and are for X210. The master branch of my fork, jwise/x2100-ec, has X2100 ports, but the x210 port just has Vladisslav2001's changes directly.

mjg59 pushed a commit to mjg59/x210-ec that referenced this pull request Jan 1, 2021
mjg59 pushed a commit to mjg59/x210-ec that referenced this pull request Jan 1, 2021
mjg59 pushed a commit to mjg59/x210-ec that referenced this pull request Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants