refactor: use time helper utilities for clearer duration conversions#100
Draft
refactor: use time helper utilities for clearer duration conversions#100
Conversation
Replace direct `.count()` uses with `count_seconds` or `count_microseconds` where the unit matters for logs and serialized timestamps. Update `p2p_handshake` fuzz bounds to express the same seconds conversion explicitly.
l0rinc
force-pushed
the
time-helpers-34328
branch
from
45337d1 to
63415ed
Compare
Use `Ticks` in mempool tracepoints and Qt ping time formatting to avoid manual duration casts and conversions. Update `scheduler_tests` to use `Ticks` for the remaining job delta calculation.
l0rinc
force-pushed
the
time-helpers-34328
branch
from
63415ed to
5c0bbbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
While investigating bitcoin#34328, I found a few remaining duration conversions that still used direct
.count()or manual division.Fix
Switch them to the existing helpers for clarity using
count_seconds,count_microsecondsandTicks.