✅ [TODO 1/1] Ensure ESM export uses .js extension#51
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,2 +1,2 @@ | |||
| export { DependencyBridgeLoader } from './dependency/dependency-bridge.loader'; | |||
| export { DependencyBridgeLoader } from './dependency/dependency-bridge.loader.js'; | |||
There was a problem hiding this comment.
The new specifier ./dependency/dependency-bridge.loader.js will cause tsc to fail to resolve the module because this package’s tsconfig still uses moduleResolution: "node" and there is no .js file in src/dependency. Under that resolver, TypeScript does not map .js imports to .ts sources (that only happens with nodenext/bundler), so pnpm build will fail before emitting either the CJS or ESM bundles. The previous extensionless import compiled correctly because the compiler automatically rewrote it to .js in the output. Consider reverting to the extensionless path or changing module resolution to nodenext before shipping this change.
Useful? React with 👍 / 👎.
kys0213
force-pushed
the
feature/core-esm-loader-extension
branch
from
34fc65e to
710fab9
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
kys0213
force-pushed
the
feature/core-esm-loader-extension
branch
from
710fab9 to
6de0b8b
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
No description provided.