Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| export * from './bridge/types.js'; | ||
| export * from './message/types.js'; | ||
| export * from './message/message.helper.js'; | ||
| export * from './message/multi-modal-content.helper.js'; | ||
| export * from './manifest/types.js'; |
There was a problem hiding this comment.
The source now uses explicit .js extensions in TypeScript imports (e.g. export * from './bridge/types.js';), but the package still compiles with moduleResolution: "node". With this resolver, TypeScript does not map ./*.js specifiers to the corresponding .ts files, so pnpm build will fail with Cannot find module './bridge/types.js' across every package. Either keep extensionless imports or switch the project to a resolver that supports ESM specifiers (node16/nodenext/bundler) before publishing.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| export * from './bridge/types.js'; | ||
| export * from './message/types.js'; | ||
| export * from './message/message.helper.js'; | ||
| export * from './message/multi-modal-content.helper.js'; | ||
| export * from './manifest/types.js'; |
There was a problem hiding this comment.
The source now uses explicit .js extensions in TypeScript imports (e.g. export * from './bridge/types.js';), but the package still compiles with moduleResolution: "node". With this resolver, TypeScript does not map ./*.js specifiers to the corresponding .ts files, so pnpm build will fail with Cannot find module './bridge/types.js' across every package. Either keep extensionless imports or switch the project to a resolver that supports ESM specifiers (node16/nodenext/bundler) before publishing.
Useful? React with 👍 / 👎.
kys0213
force-pushed
the
feature/core-dual-module-support
branch
2 times, most recently
from
7a6bb85 to
1a280f0
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting |
kys0213
force-pushed
the
feature/core-dual-module-support
branch
from
1a280f0 to
fdbfd35
Compare
1 participant
Summary