Adding Package.swift for Swift 5 versions#225
Merged
kylebrowning merged 3 commits intokylebrowning:mainfrom Jul 24, 2025
Merged
Adding Package.swift for Swift 5 versions#225kylebrowning merged 3 commits intokylebrowning:mainfrom
kylebrowning merged 3 commits intokylebrowning:mainfrom
Conversation
Contributor
|
If we want to support 5.10 we should definitely add CI for it |
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
I'm not great with CI so I asked Claude to double check my work. I'm pretty sure this should match what you did, but I'm happy to make a change if there's anything else I should do to add CI support for Swift 5. |
0xTim
approved these changes
Jul 24, 2025
Contributor
0xTim
left a comment
0xTim
left a comment
There was a problem hiding this comment.
LGTM - @kylebrowning any objections?
Owner
|
Nope! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to deploy this library to my Swift 5 server, so I had to make a new Package.swift that wasn't tied to Swift 6 to make it work.
The two changes are:
// swift-tools-version:6.0->// swift-tools-version:5.10swiftLanguageModes: [.v6]Let me know if any changes are needed, happy to accept all feedback if you have another preferred way of doing this.