[do not merge] adding mason-installed lib and include dirs#1
Open
boblannon wants to merge 3 commits intokylebgorman:masterfrom
Open
[do not merge] adding mason-installed lib and include dirs#1boblannon wants to merge 3 commits intokylebgorman:masterfrom
boblannon wants to merge 3 commits intokylebgorman:masterfrom
Conversation
Owner
|
+1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this PR for instructive purposes. This is just to show how mason can be used to install Pynini's C++ dependencies. The advantage of using mason is similar to the advantages of virtual environments: nothing depends on the state of the system or its shared libraries. The dependencies can be installed and even interlinked local to the project, making it easy to build/clean/update.
The steps to install become:
This will create a
mason_packagesfolder in the pwd, structured similarly to this (example from a laptop running OSX):setup.pyin this PR now allow you to make use of the mason-installed header files and libraries, so you can continue with installation as directed in the Pynini documentation.