store valid email in user settings

[mishasaggi]

Closes #61 and closes #130

[kylebakerio]

Looks good.

Please look into unicode-aware regex combos--what would we do for Iñtërnâtiônàlizætiøn☃💩@gmail.com? ;)

Also, please allow 'undefined' to pass through, and notify the user in the alert that an email is not mandatory, but emails entered must be valid. Consider adding 'optional' to the field name?

Thanks! :D 💃

[mishasaggi]

Is Iñtërnâtiônàlizætiøn good enough or you want to be fully inclusive towards your users and so HAVE to include 'pile of poo' unicode. :)

[kylebakerio]

I guess the question should be, 'what is a valid email address?'. If gmail (or some other carrier) allows the pile of poo character in a username, then I'd vote for handling it. Otherwise, I'd say follow their lead.

[kylebakerio]

I'm having second thoughts about this feature being on the home page. I want to make the entrance to the app as painless as possible. I'm thinking of instead moving the entire 'email' thing to an optional in-app feature only, so people aren't turned off at having to enter an email (or being rejected when they enter a bogus one). That might make the 'opt-in' character of it more obvious, and would be a better place to provide an explanation of how it is used (ideally you could opt in there to update emails, or card-ready-to-view emails, etc.).

So, what do you think of changing this to actually be a 'settings page' addition, that, right now, only includes the setting to add an email and an explanation of its usage?

(It would also make more sense to validate there.)

[mishasaggi]

I agree with moving it to the settings page. Lesser things to enter when creating an account. Don't have to add a tooltip or hover message saying emails are optional etc.

Can only think of one downside: people forget passwords and sometimes usernames too, specially when they don't use emails adds AS username. I do, for any such sites, I end up recreating accounts and then save password to the browser/ savepass. Example project euler.

So, have a recover feature for passwords using just the usernames?

[kylebakerio]

Good point. Still, indicating to users that the email field is optional, and is only for sign-up, is hard.

Maybe we could have a left/right toggle on the sign-up card with buttons that say 'login' and 'signup', that are identical except for one has an email field, and it says 'optional' in it. There were complaints that a combined login/signup form was confusing to users already, so that would kill a few birds with one stone too.

This issue is growing in scope. You could do the above instead of a settings screen, and add the settings screen as a second pull request if you like.

[kylebakerio]

🎱