Accumulate successive fixed-joint transforms left-to-right.#11
Open
marlinstrub wants to merge 1 commit intokylc:masterfrom
Open
Accumulate successive fixed-joint transforms left-to-right.#11marlinstrub wants to merge 1 commit intokylc:masterfrom
marlinstrub wants to merge 1 commit intokylc:masterfrom
Conversation
Origin tags in URDFs specify the pose of the child frame in parent-frame coordinates and should be accumulated in order of the kinematic chain, i.e., left-to-right.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Kyle
Thanks for building and maintaining this library, your time and effort is sincerely appreciated.
This PR fixes a bug in the fixed-joint folding optimization where transforms were composed in the wrong order (right-to-left instead of left-to-right), causing incorrect results for robots with sequential fixed joints.
The
origintag of a URDF joint defines the pose of the child link in the coordinate frame of the parent link. To find the pose of a (great-...) grandchild, we have to accumulate the poses in the same order as the kinematic chain.For example, this chain with two fixed joints:
The EE origin in BASE coordinates is at
Which is
T_FIXED_1 * T_FIXED_2, not the other way around.