Skip to content

Attempt to trigger leader mismatch race condition #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kyguy wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Attempt to trigger leader mismatch race condition #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bacbaa0
Ensure tests wait for broker leadership election and metadata propaga…
kyguy Dec 4, 2025
0b5197d
Attempt to trigger leader mismatch race condition
kyguy Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions ...a/com/linkedin/kafka/cruisecontrol/metricsreporter/utils/CCContainerizedKraftCluster.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,25 @@ public void shutDownBroker(int brokerId) {
timeout,
String.format("Broker %s did not shutdown properly.", brokerId)
);

// Wait until describeLogDirs fails
waitUntil(
() -> {
try {
_adminClient.describeLogDirs(Collections.singletonList(brokerId))
.allDescriptions()
.get(5, TimeUnit.SECONDS);
return false;
} catch (InterruptedException ie) {
throw new RuntimeException(ie);
} catch (Exception e) {
return true;
}
},
result -> result,
timeout,
String.format("Broker %s did not fully shut down (logDirs RPC still succeeds).", brokerId)
);
}

public static class BrokerWaitStrategy extends AbstractWaitStrategy {
Expand Down
12 changes: 10 additions & 2 deletions cruise-control/src/test/java/com/linkedin/kafka/cruisecontrol/executor/ExecutorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,9 +869,17 @@ private void executeAndVerifyProposals(AdminClient adminClient,
topic.partitions().get(tp.partition()).replicas().stream().anyMatch(rep -> r.brokerId().equals(rep.id())));
}
}
assertEquals("The leader should have moved for " + tp,
proposal.newLeader().brokerId().intValue(), topic.partitions().get(tp.partition()).leader().id());

// Wait for leader movement
//TopicDescription topicAfterLeaderMove = _cluster.waitForTopicMetadata(tp.topic(), Duration.ofSeconds(60),
// topicDescription -> topicDescription.partitions().get(tp.partition()).leader().id()
// == proposal.newLeader().brokerId());
assertEquals("The leader should have moved for " + tp
+ " proposal.newReplicas: " + proposal.newReplicas()
+ " proposal.old.replicas " + proposal.oldReplicas()
+ " topic.leader " + topic.partitions().get(tp.partition()).leader().id(),
proposal.newLeader().brokerId(),
Integer.valueOf(topic.partitions().get(tp.partition()).leader().id()));
}
if (isTriggeredByUserRequest) {
EasyMock.verify(mockUserTaskInfo, mockUserTaskManager, mockExecutorNotifier, mockLoadMonitor, mockAnomalyDetectorManager);
Expand Down
Loading