-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add date range filter to records #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ready 🫡 |
Deploying karriba with
|
| Latest commit: |
c9b2a44
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7a2cafbd.karriba.pages.dev |
| Branch Preview URL: | https://93-filter-by-date.karriba.pages.dev |
app/lib/record/records_page.dart
Outdated
| ); | ||
| } | ||
|
|
||
| Widget _buildFilterSheet() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move this to a separate RecordsFilterBottomSheet widget.
I've noticed a bug where when I select a date range, the bottom sheet still shows the previously selected date range. It doesn't update the displayed date range until I apply the date range and re-open the bottom sheet.
I think moving to a separate widget might help with this, because the setState might apply correctly.
Also, it is recommended to use widgets rather than helper methods for things like this because it improves performance - https://www.youtube.com/watch?v=IOyq-eTRhvo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved and fixed 😄 I also added a little message when no records are found to show "No records found." on the center of the page.
Pertempto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! 👍🏽
Closes #93
Changes
queryAllRowsin Records DAO.Testing