Skip to content

Conversation

@Pertempto
Copy link
Contributor

Resolves #70

- Update ESLint config to ignore .vite/deps/ directory
- Remove unused imports in MenuModal.vue, ManagePickersView.vue, PendingBinsView.vue
- Fix unused variables in DailyCountSetting.vue, PageLayout.vue
- Replace all 'any' types with proper TypeScript types
- Enable lint workflow in .github/workflows/lint.yml
- Fix TypeScript errors in v-model bindings and error refs
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 17, 2025

Deploying bintraq with  Cloudflare Pages  Cloudflare Pages

Latest commit: ab6b37f
Status: ✅  Deploy successful!
Preview URL: https://e1c2a065.bintraq.pages.dev
Branch Preview URL: https://70-fix-linting.bintraq.pages.dev

View logs

@github-actions
Copy link

github-actions bot commented Oct 17, 2025

Review

Summary of Changes

  • Enabled the lint workflow in .github/workflows/lint.yml by removing comments and activating the job steps.
  • Updated app/eslint.config.ts to ignore .vite/deps/ directory.
  • Removed unused imports from MenuModal.vue, ManagePickersView.vue, and PendingBinsView.vue.
  • Replaced any types with proper TypeScript types in models and view components, including better error handling for catch blocks.
  • Fixed minor issues like status text in DailyCountsHistoryView.vue and type assertions in AddBinView.vue and PendingBinsView.vue.
  • Updated spec file to mark all tasks as completed.

Overall Feedback

No new issues spotted – the code is much cleaner now that linting is enforced. Great work on fixing those accumulated errors, @Pertempto! 🚀

@github-actions
Copy link

Heads up @Pertempto, as the changes are linting-related and don't introduce user-facing features or fixes, appVersion doesn't need incrementing per the repo guidelines. If this changes, let me know!

@Pertempto Pertempto self-assigned this Oct 17, 2025
@Pertempto Pertempto merged commit 746b278 into main Oct 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: enable lint workflow and fix linter errors

2 participants