Skip to content

Conversation

@Pertempto
Copy link
Contributor

Related to #63

@github-actions
Copy link

github-actions bot commented Oct 17, 2025

Changes Requested

  • Improve error handling in async functions by adding toast notifications for API failures.
  • Revert messageStatuses to previous state on error in resend and refresh functions.
  • After resending, fetch and update the message status immediately.
  • Review and align the week start day (Sunday vs. Monday) in weekly count calculations and daily display.
  • Consider updating the "lost" status label for null messageUuid to something clearer like "missing" or add a tooltip explaining the status.

Summary of Changes

  • Updated spec file to mark DailyCountsHistoryView items as completed.
  • Incremented appVersion to '2025.10.17.5' in utils.ts.
  • Implemented new DailyCountsHistoryView.vue with picker filter, weekly/daily count displays, and history list with status actions.

Overall Feedback

There's still room for better error handling to prevent silent failures and improve user feedback. ⤑ Also, the date logic for weekly displays needs verification for edge cases. 👍 However, the feature is well-structured and adds nice functionality to the app!

@cloudflare-workers-and-pages
Copy link

Deploying bintraq with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3199608
Status: ✅  Deploy successful!
Preview URL: https://ffe7c5cd.bintraq.pages.dev
Branch Preview URL: https://63-daily-counts-history.bintraq.pages.dev

View logs

@github-actions
Copy link

In async functions like loadCompletedDailyCounts, loadMessageStatuses, refresh, and resend, errors are only logged to console. Consider adding user-facing error notifications (e.g., toast messages) to improve UX, as failures might go unnoticed.

@github-actions
Copy link

In resend and refresh functions, if an error occurs, the messageStatuses is set to "pending" or "refreshing" but not reverted back on failure. Consider reverting to the previous status or handling it appropriately.

@github-actions
Copy link

After resending a message in resend, consider fetching the updated status from the server to reflect any immediate changes, similar to the refresh function.

@Pertempto Pertempto merged commit f651110 into main Oct 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants