Refactor: modularize components and add centralized config #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create centralized geo config (src/config/map.config.ts) for future multi-geography support - Extract 9 sidebar components from MapLegend.tsx (710 → 240 lines) - Create useToast and useMapResize custom hooks - Rename utils.ts → map.ts for clarity - Remove duplicate CSS from globals.css - Add 12 new tests (useToast, BikeRoutes, map.config) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add event listener in MapLegend to handle route-select events dispatched from the map. Previously, clicking a route on the map would highlight it visually but not update the sidebar selection. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add project structure overview with new directories - Document centralized config for multi-geography support - Expand event-driven communication with bidirectional sync details - Add testing section with Mapbox limitations and browser testing tips
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the bikemap codebase to improve maintainability and prepare for future multi-geography support. The changes reduce complexity in large components while preserving all existing functionality.
Key Changes
1. Centralized Configuration (
src/config/map.config.ts)2. Modularized Sidebar Components (
src/components/sidebar/)BikeRoutes,MapLayers,AttractionsList,BikeResourcesList,BikeRentalListSidebarHeader,InformationSection,Footer,ToggleSwitchtypes.tsand barrel export inindex.ts3. Custom Hooks (
src/hooks/)useToast- Toast notifications with auto-dismiss and fade-outuseMapResize- Window and sidebar resize handlinguseLocationTracking- GPS location tracking (extracted)4. Utilities Consolidation
utils/utils.ts→utils/map.tsfor clarity5. CSS Cleanup
globals.css(map container, location markers, pulse animation)map-legend.css6. Bug Fix: Bidirectional Route Selection
7. New Tests
map.config.test.ts- 7 tests for configurationuseToast.test.ts- 6 tests for toast hookBikeRoutes.test.tsx- 6 tests for route selection component8. Documentation
Test Plan
pnpm test:run)pnpm lint)