fix: support date objects and other non-primitive values#10
Open
dominicbarnes wants to merge 1 commit intokvnneff:masterfrom
Open
fix: support date objects and other non-primitive values#10dominicbarnes wants to merge 1 commit intokvnneff:masterfrom
dominicbarnes wants to merge 1 commit intokvnneff:masterfrom
Conversation
39b1db7 to
ebbf1c8
Compare
Author
|
As an aside, my current workaround is to provide my own custom mapper that looks like this: function sortMapper(key, value) {
return value.valueOf()
}My first proposal was actually going to be to use |
dominicbarnes
added a commit
to dominicbarnes/pokemongo-tools
that referenced
this pull request
Jul 1, 2018
We can remove this hack once kvnneff/sort-by#10 lands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sorting by multiple props that include
Dateobjects, you'll end up with incorrect sorting in cases where the underlying date value is the same. The use of===(after checking<and>) will always returnfalseforDateobjects, since===compares identity for objects. The result of the finalresult * sortOrderbecomesNaN, which then causes iteration to stop (since the check is looking for=== 0).Just to be clear, this edge-case does not occur when you are only sorting by 1 property, it only comes up for properties following the aforementioned
Dateobjects.The change here assumes that the returned value will be
0, and will only change to-1for<and1for>. This change is backwards-compatible, and will allow non-primitive values (such asDate) to be handled more gracefully.This change also includes a test case that was failing before my change, but now passes.