Conversation
added 3 commits
April 9, 2026 09:10
- Clamp minutes to 1–20 (default 5), times to 1–3 (default 1) - Serve HTML as application/octet-stream to prevent browser JS execution - Sanitize Content-Disposition filename (strip control chars and quotes) - Re-read store before decrement to narrow concurrent-request race window
…xample, collapse double read
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Security fixes identified in code review:
.htmlasapplication/octet-streaminstead oftext/htmlto force download and prevent JS execution in browserContent-Dispositionfilename (strip control chars and quotes)/tmp— share URLs no longer survive container restarts--minutescapped at 20 (default 5),--timescapped at 3 (default 1)