fixed call to createFilterFn in onTypeAhead #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is strange, under 4.2 I encountered an error in onTypeAhead's attempt to call this.createFilterFn which was undefined.
I cannot in the history of ExtJS 4.x find a version where ComboBox has a createFilterFn method, judging by the parameters the intended method is Store.createFilterFn.
This error doesn't surface on the demo page because it runs 4.1.1, which oddly makes no use of an onTypeAhead method in ComboBox or its parents -- the override containing the error never gets called, making me wonder if it is even necessary? onTypeAhead exists in 4.1.3+ though
Store.createFilterFn returns false if the value string is blank, necessitating an extra check
I'm not sure if this onTypeAhead override is still needed, but this patch seems to fix it under versions of ExtJS that implement ComboBox.onTypeAhead