Add mechanism for a separate publishing workflow#1
Open
kurtrwall wants to merge 1 commit intostable/1.1.xfrom
Open
Add mechanism for a separate publishing workflow#1kurtrwall wants to merge 1 commit intostable/1.1.xfrom
kurtrwall wants to merge 1 commit intostable/1.1.xfrom
Conversation
wagtail/wagtailadmin/views/pages.py
Outdated
There was a problem hiding this comment.
just trying to understand the scenarios:
if page is shared & live
- then it is removed from the content site but is still visible on the www site.
- they will need to do an extra step of unpubishing it on www
if page is unshared & not live
- then they can unshare it which removes it from being visible on the content site
is this correct? @kurtw
Owner
Author
There was a problem hiding this comment.
So page.unpublish() was wrong on line 513. It should have "unshared" the page.
In terms of your question, publishing a page will make it appear on content. Unsharing won't work for pages that are on published.
kurtrwall
force-pushed
the
dual-wield-site
branch
from
f92fa88 to
b386129
Compare
kurtrwall
pushed a commit
that referenced
this pull request
Aug 8, 2016
As of taggit 0.11.0 self.tags.all() no longer performs an extra query if the tags were prefetched. See: https://github.com/alex/django-taggit/pull/140/files#diff-61d51a325171d97c8a56e59ea525339bR351
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to more easily see what was done to make the separate site publishing work.
@kave