Merged
Conversation
dgivens
approved these changes
Sep 19, 2025
- Remove non-existent pkg-config-aarch64-linux-gnu package - Use standard pkg-config and gcc-aarch64-linux-gnu packages - Install libssl-dev:arm64 for OpenSSL cross-compilation support - Add second apt-get update after adding ARM64 architecture - Apply fixes to both CI workflow and release script
- Remove dpkg --add-architecture arm64 which causes 404 errors - Remove ARM64-specific package installations - Use OPENSSL_STATIC=1 for static OpenSSL linking instead - Only install gcc-aarch64-linux-gnu cross-compiler - Simplified environment variables to reduce failure points
- Replace OPENSSL_STATIC=1 with OPENSSL_VENDORED=1 - Vendored approach builds OpenSSL from source during compilation - Avoids need for ARM64 OpenSSL development headers - Should work better for cross-compilation scenarios
- Even vendored OpenSSL builds may need system headers for configuration - Add libssl-dev installation to both CI and release workflows - Should provide fallback headers for OpenSSL compilation checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches all crates to reqwest’s rustls backend so ARM64 cross-compiles no longer pull in OpenSSL, drops the library and its vendoring flags from CI/release scripts, and keeps only the cross toolchain bits needed to build Linux ARM64 artifacts.