Skip to content

TEST PR #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Deflaimun wants to merge 3 commits into from
Closed

TEST PR #849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
312f8df
engine: fix doc feedback on mobile, after last upgrade
Deflaimun Apr 7, 2025
dc6098d
fix sticky behavior
Deflaimun Apr 7, 2025
ee25987
test
Deflaimun Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 53 additions & 57 deletions docs/.vuepress/components/TocWithFeedback.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,66 +413,62 @@ export default defineComponent({
const before = slots.before?.();
const after = slots.after?.();

const tocContent =
tocHeaders || before || after
? h("div", { class: "vp-toc-placeholder" }, [
h("aside", { id: "toc", "vp-toc": "" }, [
// Optional "before" slot
before,
// The TOC itself
tocHeaders
? [
h(
"div",
{ class: "vp-toc-header", onClick: toggleExpanded },
[
metaLocale.value.toc,
h(PrintButton),
h("div", {
class: ["arrow", isExpanded.value ? "down" : "end"],
}),
]
),
h(
"div",
{
class: [
"vp-toc-wrapper",
isExpanded.value ? "open" : "",
],
ref: toc,
return h(ClientOnly, () => {
if (!tocHeaders && !before && !after) return null;

// Main TOC container
const tocContent = h("div", { class: "vp-toc-placeholder" }, [
h("aside", { id: "toc", "vp-toc": "" }, [
before,
tocHeaders
? [
h(
"div",
{
class: "vp-toc-header",
onClick: () => toggleExpanded(),
},
[
metaLocale.value.toc,
h(PrintButton),
h("div", {
class: ["arrow", isExpanded.value ? "down" : "end"],
}),
]
),
h(
"div",
{
class: ["vp-toc-wrapper", isExpanded.value ? "open" : ""],
ref: toc,
},
[
tocHeaders,
h("div", {
class: "vp-toc-marker",
style: {
top: tocMarkerTop.value,
},
[
tocHeaders,
h("div", {
class: "vp-toc-marker",
style: { top: tocMarkerTop.value },
}),
]
),
}),
]
: null,
// Optional "after" slot
after,
// On desktop: render survey form inside the TOC container
!isMobile.value
? h("div", { class: "toc-survey-section" }, [
renderSurveyForm(),
])
: null,
]),
])
),
]
: null,
after,
// Add survey form inside the TOC for desktop
!isMobile.value
? h("div", { class: "toc-survey-section" }, [renderSurveyForm()])
: null,
]),
]);

// For mobile: create a separate teleported component
const mobileSurvey = isMobile.value
? h(Teleport, { to: ".markdown-content" }, [renderSurveyForm()])
: null;

return h(ClientOnly, () =>
h("div", {}, [
tocContent,
// On mobile: teleport the survey form to the element with class "theme-hope-content"
isMobile.value
? h(Teleport, { to: ".theme-hope-content" }, [renderSurveyForm()])
: null,
])
);
return mobileSurvey ? [tocContent, mobileSurvey] : tocContent;
});
};
},
});
});
9 changes: 7 additions & 2 deletions docs/.vuepress/styles/toc.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,14 +278,12 @@ $headings: (2, 3, 4, 5, 6);
/* The free-text textarea */
.survey-textarea {
width: 100%;
margin: 0.5rem 0;
resize: vertical; /* optional, to allow resizing */
}

/* The optional email field */
.survey-email {
width: 100%;
margin-bottom: 0.5rem;
}

/* The "Submit" button */
Expand All @@ -307,3 +305,10 @@ $headings: (2, 3, 4, 5, 6);
.survey-question {
font-weight: 600;
}

.toc-survey-section {
margin-top: 1rem;
position: relative;
z-index: 1;
}

Loading