Fix connection string and gossip timeout documentation#483
Merged
Conversation
Review Summary by QodoFix gossipTimeout documentation accuracy
WalkthroughsDescription• Corrects gossipTimeout parameter documentation • Clarifies behavior on timeout: tries next endpoint • Removes incorrect "will be retried" statement Diagramflowchart LR
A["gossipTimeout docs"] -- "incorrect: will be retried" --> B["Old description"]
A -- "correct: next endpoint tried" --> C["Updated description"]
File Changes1. docs/api/getting-started.md
|
Code Review by Qodo
|
f19e659 to
72733a5
Compare
5c2959e to
f07fbb7
Compare
f07fbb7 to
4996e3a
Compare
612a879 to
67bdd12
Compare
382ba4f to
c436644
Compare
Contributor
There was a problem hiding this comment.
🚨 @w1am Failed to create cherry Pick PR due to error:
RequestError [HttpError]: Merge conflict
at /home/runner/work/_actions/kurrent-io/Automations/master/cherry-pick-pr-for-label/node_modules/@octokit/request/dist-node/index.js:66:23
at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
status: '409',
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
'content-length': '127',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Tue, 14 Apr 2026 12:01:21 GMT',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'github.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-github-permissions': 'contents=write',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-api-version-selected': '2022-11-28',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': '5001:EF72B:124E4F5:4BFA7D6:69DE2C90',
'x-ratelimit-limit': '5000',
'x-ratelimit-remaining': '4949',
'x-ratelimit-reset': '1776171662',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '51',
'x-xss-protection': '0'
},
request: {
method: 'POST',
url: 'https://api.github.com/repos/kurrent-io/KurrentDB-Client-NodeJS/merges',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'octokit-core.js/3.3.2 Node.js/20.20.1 (linux; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: '{"base":"cherry-pick-cherry-pick/483/fix/gossip-timeout-docs-release/legacy/v6.2-d5c5af82-c632-440c-88bf-a171d862be09","commit_message":"Merge 4996e3acdbf3b4190fb28836c74fd09b734134d0 into cherry-pick-cherry-pick/483/fix/gossip-timeout-docs-release/legacy/v6.2-d5c5af82-c632-440c-88bf-a171d862be09 [skip ci]\\n\\n\\nskip-checks: true\\n","head":"4996e3acdbf3b4190fb28836c74fd09b734134d0"}',
request: { agent: [Agent], hook: [Function: bound bound register] }
},
documentation_url: 'https://docs.github.com/rest/branches/branches#merge-a-branch'
}
🚨👉 Check https://github.com/kurrent-io/KurrentDB-Client-NodeJS/actions/runs/24397734483
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix gossipTimeout description which incorrectly stated the gossip call will be retried on timeout. It actually moves on to the next candidate endpoint.
Clarify that kurrentdb+discover:// only uses a single DNS endpoint. If multiple hosts are specified, only the first is used and the rest are ignored. Recommend kurrentdb:// with multiple gossip seeds for redundancy when individual node addresses are known.