Allow server-side filtering for readAll method#405
Closed
aovens-quantifi wants to merge 1 commit intokurrent-io:masterfrom
Closed
Allow server-side filtering for readAll method#405aovens-quantifi wants to merge 1 commit intokurrent-io:masterfrom
aovens-quantifi wants to merge 1 commit intokurrent-io:masterfrom
Conversation
|
|
aovens-quantifi
changed the title
Contributor
Author
|
It doesn't appear these test failures are related to my change |
Collaborator
|
Hey @aovens-quantifi . Thank you for your work! We believe integrating your code into the rebranded client is the best approach since this one will be deprecated upon release. But, the rebranded client relies on the Rust client internally for better performance. I'll make sure to credit you as a co-author once we complete the filtered reads implementation in the Rust client |
Contributor
Author
|
Awesome! Thanks :) |
Contributor
|
done here: #406 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only the subscribeToAll method allows server side filtering. This PR adds the same capability to the readAll method.