Skip to content

fix: prevent NRE on transport level gRPC errors #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
w1am merged 1 commit into from
Apr 14, 2026
Merged

fix: prevent NRE on transport level gRPC errors #405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/KurrentDB.Client/Core/Exceptions/AccessDeniedException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ public AccessDeniedException() : base("Access denied.") {

}

public static AccessDeniedException FromRpcException(RpcException ex) => FromRpcStatus(ex.GetRpcStatus()!);
public static AccessDeniedException FromRpcException(RpcException ex) =>
FromRpcStatus(ex.GetRpcStatus() ?? throw ex);

Comment thread
w1am marked this conversation as resolved.
public static AccessDeniedException FromRpcStatus(Google.Rpc.Status ex) {
return new(ex.Message, ex.ToRpcException());
Expand Down
3 changes: 2 additions & 1 deletion src/KurrentDB.Client/Core/Exceptions/AppendTransactionMaxSizeExceededException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ public class AppendTransactionMaxSizeExceededException(int size, int maxSize, Ex
/// </summary>
public int MaxSize { get; } = maxSize;

public static AppendTransactionMaxSizeExceededException FromRpcException(RpcException ex) => FromRpcStatus(ex.GetRpcStatus()!);
public static AppendTransactionMaxSizeExceededException FromRpcException(RpcException ex) =>
FromRpcStatus(ex.GetRpcStatus() ?? throw ex);
Comment thread
w1am marked this conversation as resolved.

public static AppendTransactionMaxSizeExceededException FromRpcStatus(Google.Rpc.Status ex) {
var details = ex.GetDetail<AppendTransactionSizeExceededErrorDetails>();
Expand Down
3 changes: 2 additions & 1 deletion src/KurrentDB.Client/Core/Exceptions/NotLeaderException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ public NotLeaderException(string host, int port, Exception? exception = null) :
LeaderEndpoint = new DnsEndPoint(host, port);
}

public static NotLeaderException FromRpcException(RpcException ex) => FromRpcStatus(ex.GetRpcStatus()!);
public static NotLeaderException FromRpcException(RpcException ex) =>
FromRpcStatus(ex.GetRpcStatus() ?? throw ex);
Comment thread
w1am marked this conversation as resolved.

public static NotLeaderException FromRpcStatus(Google.Rpc.Status ex) {
var details = ex.GetDetail<NotLeaderNodeErrorDetails>();
Expand Down
3 changes: 2 additions & 1 deletion src/KurrentDB.Client/Core/Exceptions/StreamTombstonedException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ public StreamTombstonedException(string stream, Exception? exception = null)
Stream = stream;
}

public static StreamTombstonedException FromRpcException(RpcException ex) => FromRpcStatus(ex.GetRpcStatus()!);
public static StreamTombstonedException FromRpcException(RpcException ex) =>
FromRpcStatus(ex.GetRpcStatus() ?? throw ex);
Comment thread
w1am marked this conversation as resolved.

public static StreamTombstonedException FromRpcStatus(Google.Rpc.Status ex) {
var details = ex.GetDetail<StreamTombstonedErrorDetails>();
Expand Down
3 changes: 2 additions & 1 deletion src/KurrentDB.Client/Core/Exceptions/WrongExpectedVersionException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ public WrongExpectedVersionException(string streamName, StreamState expectedStre
ActualVersion = actualStreamState.ToInt64();
}

public static WrongExpectedVersionException FromRpcException(RpcException ex) => FromRpcStatus(ex.GetRpcStatus()!);
public static WrongExpectedVersionException FromRpcException(RpcException ex) =>
FromRpcStatus(ex.GetRpcStatus() ?? throw ex);
Comment thread
w1am marked this conversation as resolved.

public static WrongExpectedVersionException FromRpcStatus(Google.Rpc.Status ex) {
var details = ex.GetDetail<StreamRevisionConflictErrorDetails>();
Expand Down
3 changes: 1 addition & 2 deletions src/KurrentDB.Client/Streams/KurrentDBClient.MultiAppend.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,7 @@ await session.RequestStream

return new MultiStreamAppendResponse(response.Position, responses);
} catch (RpcException ex) {
var status = ex.GetRpcStatus()!;
throw status.GetDetail<ErrorInfo>() switch {
throw ex.GetRpcStatus()?.GetDetail<ErrorInfo>() switch {
{ Reason: "STREAM_REVISION_CONFLICT" } => WrongExpectedVersionException.FromRpcException(ex),
Comment thread
w1am marked this conversation as resolved.
{ Reason: "STREAM_TOMBSTONED" } => StreamTombstonedException.FromRpcException(ex),
{ Reason: "APPEND_RECORD_SIZE_EXCEEDED" } => AppendRecordSizeExceededException.FromRpcException(ex),
Expand Down
3 changes: 2 additions & 1 deletion src/KurrentDB.Client/Streams/MaximumAppendSizeExceededException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ public AppendRecordSizeExceededException(string stream, string recordId, long si
MaxSize = maxSize;
}

public static AppendRecordSizeExceededException FromRpcException(RpcException ex) => FromRpcStatus(ex.GetRpcStatus()!);
public static AppendRecordSizeExceededException FromRpcException(RpcException ex) =>
FromRpcStatus(ex.GetRpcStatus() ?? throw ex);
Comment thread
w1am marked this conversation as resolved.

public static AppendRecordSizeExceededException FromRpcStatus(Google.Rpc.Status ex) {
var details = ex.GetDetail<AppendRecordSizeExceededErrorDetails>();
Expand Down
Loading