Skip to content

Update TaskCompletionSource constructor to use TaskCreationOptions.RunContinuationsAsynchronously #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
salgatbp wants to merge 1 commit into from
Closed

Update TaskCompletionSource constructor to use TaskCreationOptions.RunContinuationsAsynchronously #400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/KurrentDB.Client/Streams/KurrentDBClient.Append.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ Action<Exception> onException
_onException = onException;
_channel = System.Threading.Channels.Channel.CreateBounded<BatchAppendReq>(10000);
_pendingRequests = new ConcurrentDictionary<Uuid, TaskCompletionSource<IWriteResult>>();
_isUsable = new TaskCompletionSource<bool>();
_isUsable = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);

_ = Task.Run(() => Duplex(channelInfoTask), cancellationToken);
}
Expand Down Expand Up @@ -242,7 +242,7 @@ CancellationToken cancellationToken
async ValueTask<IWriteResult> Operation() {
var correlationId = Uuid.NewUuid();

var complete = _pendingRequests.GetOrAdd(correlationId, new TaskCompletionSource<IWriteResult>());
var complete = _pendingRequests.GetOrAdd(correlationId, new TaskCompletionSource<IWriteResult>(TaskCreationOptions.RunContinuationsAsynchronously));
Copy link
Copy Markdown

@Salgat Salgat Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not relevant to this PR.


try {
foreach (var appendRequest in GetRequests(events, options, correlationId))
Expand Down
2 changes: 1 addition & 1 deletion src/KurrentDB.Client/Streams/KurrentDBClient.Read.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ CancellationToken cancellationToken

StreamName = request.Options.Stream.StreamIdentifier!;

var tcs = new TaskCompletionSource<ReadState>();
var tcs = new TaskCompletionSource<ReadState>(TaskCreationOptions.RunContinuationsAsynchronously);
_cts = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken);
var linkedCancellationToken = _cts.Token;
#pragma warning disable CS0612
Expand Down
Loading