Added test cases for backend module for serialisation#11
Open
monil wants to merge 2 commits intokuroidoruido:masterfrom
Open
Added test cases for backend module for serialisation#11monil wants to merge 2 commits intokuroidoruido:masterfrom
monil wants to merge 2 commits intokuroidoruido:masterfrom
Conversation
monil
changed the title
kuroidoruido
requested changes
Oct 5, 2020
| <groupId>org.hamcrest</groupId> | ||
| <artifactId>hamcrest</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> |
Owner
There was a problem hiding this comment.
can you rebase your branch on master, these dependencies was already added
|
|
||
|
|
||
|
|
||
|
|
Owner
There was a problem hiding this comment.
can you remove these useless blank lines?
| List<User> user = shieldDBGson.toList("[{\"name\":\"shieldDB\"}]"); | ||
|
|
||
| assertEquals(1,user.size()); | ||
|
|
Owner
There was a problem hiding this comment.
can you remove this useless blank line?
|
|
||
| assertEquals("[{\"name\":\"shieldDB\"}]",shieldDBGson.toJson | ||
| (Arrays.asList(new User("shieldDB")))); | ||
|
|
Owner
There was a problem hiding this comment.
can you remove this useless blank line?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test cases for sheilddb-gson-backend component covering following