Conversation
…array lists, getWritten -> written
kubkon
left a comment
kubkon
left a comment
There was a problem hiding this comment.
Looks great, thanks! I would just like to revert a couple of stylistic changes that slipped through in this PR that IMHO should not part of this PR as they are not a matter of personal taste and are tangential to the core of the PR.
src/Yaml/test.zig
Outdated
| const stringify = @import("../stringify.zig").stringify; | ||
| const testing = std.testing; | ||
|
|
||
| const Arena = std.heap.ArenaAllocator; | ||
|
|
||
| const stringify = @import("../stringify.zig").stringify; |
There was a problem hiding this comment.
I do not think this refactoring effort should not be part of this PR.
src/Yaml.zig
Outdated
| const log = std.log.scoped(.yaml); | ||
|
|
||
| const Allocator = mem.Allocator; | ||
| const ArenaAllocator = std.heap.ArenaAllocator; | ||
| const ErrorBundle = std.zig.ErrorBundle; | ||
| const Node = Tree.Node; | ||
|
|
||
| const Parser = @import("Parser.zig"); | ||
| const ParseError = Parser.ParseError; | ||
| const Tokenizer = @import("Tokenizer.zig"); | ||
| const Token = Tokenizer.Token; | ||
| const Tree = @import("Tree.zig"); | ||
| const Node = Tree.Node; | ||
|
|
||
| const log = std.log.scoped(.yaml); | ||
|
|
There was a problem hiding this comment.
I do not think this refactoring effort should not be part of this PR.
| const Tokenizer = @This(); | ||
|
|
||
| const std = @import("std"); | ||
| const log = std.log.scoped(.tokenizer); | ||
| const testing = std.testing; | ||
|
|
||
| const Tokenizer = @This(); | ||
|
|
||
| const log = std.log.scoped(.tokenizer); |
There was a problem hiding this comment.
I do not think this refactoring effort should not be part of this PR.
src/Parser/test.zig
Outdated
| const Parser = @import("../Parser.zig"); | ||
| const Tree = @import("../Tree.zig"); | ||
| const List = Tree.List; | ||
| const Map = Tree.Map; | ||
| const Node = Tree.Node; | ||
| const Parser = @import("../Parser.zig"); | ||
| const Tree = @import("../Tree.zig"); | ||
|
|
There was a problem hiding this comment.
I do not think this refactoring effort should not be part of this PR.
|
No problemo, reverted those cosmetic ones! |
|
Nice! I was looking to upgrade a project using this to 0.15.1 and planned on making these changes, but it looks like you've already beat me to it! |
|
👋 hey just checkin if there were any other changes you'd like to see. would be dope to get this merged! thanks a bunch! |
|
Hi! Sorry for the delay in getting this landed - life happened. Anyhow, I'll focus on getting this landed ASAP. |
I totally know the feeling! Thanks a bunch for this project and all your work! |
3 participants
👋 hey there, I just was updating a project of mine to use 0.15.1 zig and had this patch to get zig-yaml playing nicely there as well. really super minimal changes to use the managed array list. happy to tweak or close but just figured id share since id already got it working!