-
Notifications
You must be signed in to change notification settings - Fork 111
fix(sig-ci): update chairs since brianmcarey left #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Also update the meeting times for sig-ci meeting and quarantine catchup meeting. Signed-off-by: Daniel Hiller <dhiller@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
iholder101
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
| time: "10:00" | ||
| tz: CET | ||
| frequency: weekly | ||
| url: https://zoom.us/j/96583958896 | ||
| archive_url: https://docs.google.com/document/d/1pWg6JvjStffoZ0NnVk4ALQOs3MYOdHtBpkLBlJlHTqA/edit | ||
| - description: KubeVirt tests quarantine catch-up | ||
| day: Wednesday | ||
| time: "08:45" | ||
| time: "09:45" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these related? Just making sure it's not a typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this is just a fix, since the meetings always happens on 9:45 AM CE(S)T. This is correctly seen in the KubeVirt calendar but wrong here.
|
New changes are detected. LGTM label has been removed. |
|
There are empty aliases in OWNER_ALIASES, cleanup is advised. |
| sig-ci-reviewers: | ||
| - brianmcarey | ||
| - dhiller | ||
| - dollierp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @dollierp
|
/cc @brianmcarey |
9a2848c to
58dbaf8
Compare
|
There are empty aliases in OWNER_ALIASES, cleanup is advised. |
Adds a section into the sig-list.md that mentions the emeritus leads, should they be present. This change specifically moves @brianmcarey into the emeritus_approvers section in the OWNERS and removes him from the approvers sections in OWNERS_ALIASES. Also an emeritus_leads section is added for him. Signed-off-by: Daniel Hiller <dhiller@redhat.com>
58dbaf8 to
68c9371
Compare
brianmcarey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks @dhiller
What this PR does / why we need it:
Remove @brianmcarey from chairs of sig-ci since he has left the project 🥹
Also update the meeting times for sig-ci meeting and quarantine catchup meeting.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/cc @aburdenthehand