-
Notifications
You must be signed in to change notification settings - Fork 69
β¨ Added docs source actions (view source file, open issue, compose PR) #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome to KubeStellar! π Thank you for submitting this Pull Request. Before your PR can be merged, please ensure: β
DCO Sign-off - All commits must be signed off with β
PR Title - Must start with an emoji: β¨ (feature), π (bug fix), π (docs), π± (infra/tests), Getting Started with KubeStellar:
Contributor Resources:
π Help KubeStellar Grow - We Need Adopters! Our roadmap is driven entirely by adopter feedback. Whether you're using KubeStellar yourself or know someone who could benefit from multi-cluster Kubernetes: π Take our Multi-Cluster Survey - Share your use cases and help shape our direction! A maintainer will review your PR soon. Feel free to ask questions in the comments or on Slack! |
|
Hi @xonas1101. Thanks for your PR. I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
β Deploy Preview for kubestellar-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/cc @MikeSpreitzer |
|
/ok-to-test |
|
Hi @MikeSpreitzer I looked into this, and its basically functional right? I will just format this button like the other two. Also, I'll make the button take the user to /fork endpoint if no fork exists on the user's account. For the admin access accounts, I'll try to find a way to still enforce making changes on the user's fork. |
|
@xonas1101: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
b3925bb to
217c788
Compare
|
/retest |
|
@xonas1101: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@clubanderson @MikeSpreitzer I have performed the changes for Compose a PR button, I have checked with an account that has a fork of ks/docs, and one that does not have a fork already. All that's left is to see for the accounts that have admin access. Please lmk if further changes are needed, or we have the desired functionality. |
|
@MikeSpreitzer @clubanderson I think the PR is currently blocked on |
Signed-off-by: xonas1101 <aarushsingh1305@gmail.com>
Signed-off-by: xonas1101 <aarushsingh1305@gmail.com>
Signed-off-by: xonas1101 <aarushsingh1305@gmail.com>
Signed-off-by: xonas1101 <aarushsingh1305@gmail.com>
Signed-off-by: xonas1101 <aarushsingh1305@gmail.com>
Signed-off-by: xonas1101 <aarushsingh1305@gmail.com>
Signed-off-by: xonas1101 <aarushsingh1305@gmail.com>
217c788 to
27dde79
Compare
|
@MikeSpreitzer @clubanderson I have resolved the merge conflicts popping up in EditPageLink.tsx. |
|
As a follow-up issue, we maybe can remove EditPageLink.tsx after this PR, since all the work done in that file is now moved to DocsSourceActions.tsx with extra features and a bit refactoring. |


π Fixes
Fixes #780
π Summary of Changes
Adds two clear actions to documentation pages:
This replaces the previous edit-only icon with clearer, safer actions.
Changes Made
Checklist
Please ensure the following before submitting your PR:
Screenshots or Logs (if applicable)
π Reviewer Notes