fix: scan private registries #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meysam <meysam@developer-friendly.blog>
Signed-off-by: Meysam <meysam@developer-friendly.blog>
Signed-off-by: Meysam <meysam@developer-friendly.blog>
Contributor
Author
Contributor
|
@meysam81 thanks for the suggestion, I'd like to have a renovabot action to maintain the image tag up-to-date please! |
Contributor
|
actually I wonder if we don't have it already? I saw another PR with v3.0.21 |
Contributor
Author
|
Well @matthyx , I love renovatebot and I fully support your decision. But, please, whatever you end up executing, we want this yesterday :) The official kubescape-action is not working for private images :( |
Contributor
|
does #70 solve your issue? |
Contributor
Author
|
no, it does not this line is failing the CI: Line 149 in c9749b8 |
Signed-off-by: Meysam <meysam@developer-friendly.blog>
matthyx
approved these changes
Dec 2, 2024
meysam81
added a commit
to meysam81/build-docker
that referenced
this pull request
Dec 8, 2024
this comes only after fixing kubescape/github-action#68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #67
Full context:
Currently, the private registry docker images cannot be scanned, even when providing credentials, even when using GitHub PAT.
With the changes in this PR, I was once again able to scan images normally without issue.
P.S. Please install dependabot or renovatebot. I'll be happy to contribute on that side too if I get a confirmation from the maintainers.