Skip to content

Conversation

@rramkumar1
Copy link
Contributor

This is a cosmetic change..since the purpose of the code is for user interaction, it probably makes more sense in cmd/ anyways.

/assign @hakman

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 5, 2026
@k8s-ci-robot k8s-ci-robot requested review from hakman and zetaab January 5, 2026 16:40
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 5, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @rramkumar1. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hakman. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 5, 2026
@ameukam
Copy link
Member

ameukam commented Jan 5, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 5, 2026
@hakman
Copy link
Member

hakman commented Jan 6, 2026

@rramkumar1 We usually keep cmd without utils logic. I'd prefer to not do this change.
/cc @justinsb @rifelpet

@rramkumar1
Copy link
Contributor Author

rramkumar1 commented Jan 6, 2026

@rramkumar1 We usually keep cmd without utils logic. I'd prefer to not do this change. /cc @justinsb @rifelpet

Got it, I had noticed a utils directory already in cmd so that's why I assumed it was okay but totally fine to close this regardless.

@hakman
Copy link
Member

hakman commented Jan 6, 2026

Thanks @rramkumar1! 😊
/close

@k8s-ci-robot
Copy link
Contributor

@hakman: Closed this PR.

Details

In response to this:

Thanks @rramkumar1! 😊
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants