-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Move UI utilities to cmd/ since they are only used there #17847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @rramkumar1. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
efe582b to
3c2c00a
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/ok-to-test |
3c2c00a to
944e9fa
Compare
|
@rramkumar1 We usually keep cmd without utils logic. I'd prefer to not do this change. |
Got it, I had noticed a utils directory already in cmd so that's why I assumed it was okay but totally fine to close this regardless. |
|
Thanks @rramkumar1! 😊 |
|
@hakman: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is a cosmetic change..since the purpose of the code is for user interaction, it probably makes more sense in cmd/ anyways.
/assign @hakman