-
Notifications
You must be signed in to change notification settings - Fork 182
feat(build): migrate content ingestion to hugo modules #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| module github.com/kubernetes-sigs/contributor-site | ||
|
|
||
| go 1.22.4 | ||
|
|
||
| toolchain go1.22.5 | ||
|
|
||
| // Dependencies are pinned to specific versions (commit hashes) to ensure build | ||
| // reproducibility and stability. They are NOT updated automatically on every | ||
| // upstream commit. To update content, run 'make modules-get'. | ||
| require ( | ||
| github.com/cncf/foundation v0.0.0-20260213115547-899b0de7f20d // indirect | ||
| github.com/kubernetes/sig-release v0.0.0-20260213154600-4664fda9dd9b // indirect | ||
| k8s.io/community v0.0.0-20260214141759-4bea83be3fe0 // indirect | ||
| ) |
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Under what circumstances will these values change?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. With these changes... when someone manually runs hugo mod get. This isn't ideal. But right now, we run the latest changes always from every project, so we also have some security/stability risks because we also run the risk of breaking the site every time there's new content in every other repo and page. I would like to know what you guys like most:
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For example something like |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| github.com/cncf/foundation v0.0.0-20260202205210-94f5c56dccf4 h1:BWKfIbicTFE8C2QgQS4uTtvcfc97qWVeGZUE9mOC+t8= | ||
| github.com/cncf/foundation v0.0.0-20260202205210-94f5c56dccf4/go.mod h1:Bc+TWRzbCv6T+tkQqNuwGA3cGk017o2TE5CAmu9EY/Q= | ||
| github.com/cncf/foundation v0.0.0-20260213115547-899b0de7f20d h1:b9WxNhDNhAvGHn677OkjIlSTkl+b0N2O1x+5CCjxhc4= | ||
| github.com/cncf/foundation v0.0.0-20260213115547-899b0de7f20d/go.mod h1:Bc+TWRzbCv6T+tkQqNuwGA3cGk017o2TE5CAmu9EY/Q= | ||
| github.com/kubernetes/sig-release v0.0.0-20260202214826-624822f8822c h1:l7+EGkMqg/SBK2bY28ZgnuHW0PfLHr2L3TIAE3O8D0o= | ||
| github.com/kubernetes/sig-release v0.0.0-20260202214826-624822f8822c/go.mod h1:sNxEc7U86IjC93kZywZHM8psA/Moy8DMXXwP2N+EAe0= | ||
| github.com/kubernetes/sig-release v0.0.0-20260213154600-4664fda9dd9b h1:Kd2CNI54Ny0QuWiiEPws3FAysot+QRIbdVt9zrDW2tA= | ||
| github.com/kubernetes/sig-release v0.0.0-20260213154600-4664fda9dd9b/go.mod h1:sNxEc7U86IjC93kZywZHM8psA/Moy8DMXXwP2N+EAe0= | ||
| k8s.io/community v0.0.0-20260203101630-a24805997f22 h1:f+gIgCWlPdh6Gvxsm9muQHR12ZSaGThLVzlgf5aShqA= | ||
| k8s.io/community v0.0.0-20260203101630-a24805997f22/go.mod h1:xtSUbAS2+b+VSyXBArm0L8NyzxCRQnrZj1PrFq2v1Zw= | ||
| k8s.io/community v0.0.0-20260214141759-4bea83be3fe0 h1:HlCv+8PcjEC9K/ytuYfTp/ZJagIFnwl1xEbuLUWU3FI= | ||
| k8s.io/community v0.0.0-20260214141759-4bea83be3fe0/go.mod h1:xtSUbAS2+b+VSyXBArm0L8NyzxCRQnrZj1PrFq2v1Zw= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have any security implications?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cache has to be read-write for development. I mitigated this risk by reducing the privileges in the development container in the following commits.