Skip to content

fix(calendar): remove hardcoded api key and inject via env var #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TineoC wants to merge 2 commits into
base: master
Choose a base branch
from
+34 −5
Open

fix(calendar): remove hardcoded api key and inject via env var #623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
626f561
fix(calendar): remove hardcoded api key and inject via env var
TineoC Mar 20, 2026
1ccdc9c
fix(calendar): fix api key injection and add fallback params
TineoC Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions hugo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ params:
copyright: The Kubernetes Authors
gcs_engine_id: 8ad0f1b8442fece81

google_calendar_api_key: ""

# User interface configuration
ui:
# Enable to show the sidebar menu in its compact state.
Expand Down
14 changes: 12 additions & 2 deletions layouts/calendar/baseof.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,23 @@
<!doctype html>
<html itemscope itemtype="http://schema.org/WebPage" lang="{{ .Site.Language.Lang }}" class="no-js">
<html {{ if hugo.IsProduction }}data-isproduction="true"{{ end }} itemscope itemtype="http://schema.org/WebPage" lang="{{ .Site.Language.Lang }}" class="no-js">
<head>
{{ partial "head.html" . }}
<link href='{{ .Site.BaseURL }}/css/fullcalendar/main.min.css' rel='stylesheet' />
<link href='{{ .Site.BaseURL }}/css/calendar-responsive.css' rel='stylesheet' />
<script src='{{ .Site.BaseURL }}/js/fullcalendar/main.min.js'></script>
<script src='{{ .Site.BaseURL }}/js/calendar.js'></script>
<script>
renderCalendar();
{{ $apiKey := getenv "HUGO_GOOGLE_CALENDAR_API_KEY" }}
{{ if not $apiKey }}
{{ $apiKey = .Site.Params.google_calendar_api_key | default "" }}
{{ end }}

{{ if hugo.IsProduction }}
{{ if not $apiKey }}
{{ errorf "Google Calendar API key is required for production builds (set via HUGO_GOOGLE_CALENDAR_API_KEY environment variable or google_calendar_api_key site parameter)" }}
{{ end }}
{{ end }}
renderCalendar({{ $apiKey | jsonify | safeJS }});
</script>
</head>
<body class="td-{{ .Kind }}{{ with .Page.Params.body_class }} {{ . }}{{ end }}">
Expand Down
23 changes: 20 additions & 3 deletions static/js/calendar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,29 @@ function openEvent(event) {
return false;
};

function renderCalendar() {
document.addEventListener('DOMContentLoaded', function () {
function renderCalendar(apiKey) {
document.addEventListener('DOMContentLoaded', function() {
var calendarEl = document.getElementById('calendar');

if (!calendarEl) {
Copy link
Copy Markdown
Member

@lmktfy lmktfy Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A trick: we can set eg data-isproduction on the root <html> element. But we only do that for production builds, and then client side we know if a calendar / API key is expected.

Copy link
Copy Markdown
Contributor Author

@TineoC TineoC Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like this?

<html {{ if hugo.IsProduction }}data-isproduction="true"{{ end }}>

console.error('Calendar element not found. Cannot render calendar.');
return;
}

var isProduction = document.documentElement.getAttribute('data-isproduction') === 'true';

if (!apiKey) {
if (isProduction) {
console.error('Google Calendar API key is missing in production. Calendar will not render.');
} else {
console.warn('Google Calendar API key is missing. Calendar will not render.');
}
calendarEl.innerHTML = '<div class="alert alert-warning">Community Calendar is not available in this environment (missing API Key).</div>';
return;
}

var calendar = new FullCalendar.Calendar(calendarEl, {
googleCalendarApiKey: 'AIzaSyDn_UhFPLDgxouI5nc8hOULFY25EjwGR44',
googleCalendarApiKey: apiKey,
events: {
googleCalendarId: 'calendar@kubernetes.io'
},
Expand Down