Deploying HPC webhook to the cluster#540
Conversation
|
/retest pull-e2e-capz-windows-2022-extension |
|
/test pull-e2e-capz-windows-2022-extension |
andyzhangx
left a comment
There was a problem hiding this comment.
what is hpc webhook? can you add more description in the PR?
added |
|
/retest |
|
/retest pull-e2e-capz-windows-2022-extension |
|
@zylxjtu: The Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
9a1932b to
27b0b55
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marosset, zylxjtu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In order to restore full Windows support for the image pull E2E tests by enabling Windows nodes to participate in the fake registry–based testing flow, while keeping the test logic shared and consistent across platforms.
(1) Extend agnhost Windows Image to Support Fake Registry Server:
kubernetes/kubernetes@979f73b
(2): The common image pull tests will be updated to include Windows nodes, with the following adaptations:
(a) Deploy Fake Registry as a Windows HostProcess Pod
(b) Adjust Command-Line Options for Windows Containers
As explained here, windows hpc container will need to do some tweaks on the commandline
But making os runtime dependent change in the common test framework will be difficult even impossible kubernetes/test/e2e/framework/registry/registry.go at master · kubernetes/kubernetes
The proposal is to run a webhook under the hood to do the trick to manipulate the related command-line changes
this is what this PR is trying to do, beside this, it also provides the cleanest mechanism to:
Avoid OS-specific logic in shared E2E test code
Preserve parity with Linux test behavior
Enable reuse for other Windows-specific scenarios