Skip to content

Deploying HPC webhook to the cluster#540

Merged
zylxjtu merged 1 commit intokubernetes-sigs:masterfrom
zylxjtu:master
Feb 12, 2026
Merged

Deploying HPC webhook to the cluster#540
zylxjtu merged 1 commit intokubernetes-sigs:masterfrom
zylxjtu:master

Conversation

@zylxjtu
Copy link
Contributor

@zylxjtu zylxjtu commented Feb 9, 2026

In order to restore full Windows support for the image pull E2E tests by enabling Windows nodes to participate in the fake registry–based testing flow, while keeping the test logic shared and consistent across platforms.

(1) Extend agnhost Windows Image to Support Fake Registry Server:
kubernetes/kubernetes@979f73b

(2): The common image pull tests will be updated to include Windows nodes, with the following adaptations:

(a) Deploy Fake Registry as a Windows HostProcess Pod

(b) Adjust Command-Line Options for Windows Containers

As explained here, windows hpc container will need to do some tweaks on the commandline

But making os runtime dependent change in the common test framework will be difficult even impossible kubernetes/test/e2e/framework/registry/registry.go at master · kubernetes/kubernetes

The proposal is to run a webhook under the hood to do the trick to manipulate the related command-line changes
this is what this PR is trying to do, beside this, it also provides the cleanest mechanism to:

Avoid OS-specific logic in shared E2E test code
Preserve parity with Linux test behavior
Enable reuse for other Windows-specific scenarios

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 9, 2026
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 9, 2026
@zylxjtu
Copy link
Contributor Author

zylxjtu commented Feb 9, 2026

/retest pull-e2e-capz-windows-2022-extension

@zylxjtu
Copy link
Contributor Author

zylxjtu commented Feb 9, 2026

/test pull-e2e-capz-windows-2022-extension

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is hpc webhook? can you add more description in the PR?

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 10, 2026
@zylxjtu zylxjtu requested a review from andyzhangx February 10, 2026 17:53
@zylxjtu
Copy link
Contributor Author

zylxjtu commented Feb 10, 2026

what is hpc webhook? can you add more description in the PR?

added

@zylxjtu
Copy link
Contributor Author

zylxjtu commented Feb 10, 2026

/retest

@zylxjtu
Copy link
Contributor Author

zylxjtu commented Feb 10, 2026

/retest pull-e2e-capz-windows-2022-extension

@k8s-ci-robot
Copy link
Contributor

@zylxjtu: The /retest command does not accept any targets.
The following commands are available to trigger optional jobs:

/test pull-e2e-capz-validate-pr-templates
/test pull-e2e-capz-windows-2022-azure-ccm
/test pull-e2e-capz-windows-2022-azure-file
/test pull-e2e-capz-windows-2022-extension
/test pull-e2e-capz-windows-2022-extension-community-eks
/test pull-e2e-capz-windows-2022-extension-community-gke
/test pull-e2e-capz-windows-2022-extension-gmsa
/test pull-e2e-capz-windows-2022-staging-gallery
/test pull-e2e-capz-windows-2025-extension
/test pull-e2e-capz-windows-2025-staging-gallery
/test pull-e2e-run-capz-sh-windows-2022-hyperv
/test pull-kubernetes-e2enode-windows
/test pull-kubernetes-unit-windows

Use /test all to run the following jobs that were automatically triggered:

pull-e2e-capz-windows-2022-extension
pull-e2e-capz-windows-2025-extension
pull-kubernetes-e2enode-windows
pull-kubernetes-unit-windows
Details

In response to this:

/retest pull-e2e-capz-windows-2022-extension

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zylxjtu zylxjtu force-pushed the master branch 2 times, most recently from 9a1932b to 27b0b55 Compare February 10, 2026 22:58
@zylxjtu zylxjtu changed the title Adding HPC webhook to the cluster Deploying HPC webhook to the cluster Feb 11, 2026
Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset, zylxjtu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2026
@zylxjtu zylxjtu merged commit d6234f2 into kubernetes-sigs:master Feb 12, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments