Skip to content

docs: clarify CNI readiness reporter as DaemonSet instead of sidecar#181

Open
Hii-Himanshu wants to merge 1 commit intokubernetes-sigs:mainfrom
Hii-Himanshu:docs-calico-readiness-daemonset
Open

docs: clarify CNI readiness reporter as DaemonSet instead of sidecar#181
Hii-Himanshu wants to merge 1 commit intokubernetes-sigs:mainfrom
Hii-Himanshu:docs-calico-readiness-daemonset

Conversation

@Hii-Himanshu
Copy link
Copy Markdown
Contributor

This PR updates the documentation to correctly describe the deployment of the CNI readiness reporter.

Previously, it was described as a sidecar injected into the Calico deployment, which is inaccurate.

This change clarifies that:

  • A separate DaemonSet is deployed
  • It runs alongside Calico
  • It updates node condition based on CNI readiness

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Hii-Himanshu
Once this PR has been reviewed and has the lgtm label, please assign sergeykanzhelev for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 30, 2026

Deploy Preview for node-readiness-controller canceled.

Name Link
🔨 Latest commit e287e6d
🔍 Latest deploy log https://app.netlify.com/projects/node-readiness-controller/deploys/69c9f363f2cbda0008155ea4

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 30, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @Hii-Himanshu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants