Skip to content

fix: taint optimistic locking#180

Open
jpschmitt02 wants to merge 1 commit intokubernetes-sigs:mainfrom
jpschmitt02:fix-taint-optimistic-locking
Open

fix: taint optimistic locking#180
jpschmitt02 wants to merge 1 commit intokubernetes-sigs:mainfrom
jpschmitt02:fix-taint-optimistic-locking

Conversation

@jpschmitt02
Copy link
Copy Markdown

Description

Switch to optimistic lock when updating taints to avoid race conditions.

Related Issue

Fixes #179

Type of Change

/kind bug

Testing

Tested in dev cluster intermittently experiencing a race condition with Karpenter registration taint.

Checklist

  • make test passes
  • make lint passes

Does this PR introduce a user-facing change?

No.

NONE

Doc #(issue)

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 27, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 27, 2026

Deploy Preview for node-readiness-controller canceled.

Name Link
🔨 Latest commit 77ac597
🔍 Latest deploy log https://app.netlify.com/projects/node-readiness-controller/deploys/69c6adcaf8699c000887adea

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jpschmitt02
Once this PR has been reviewed and has the lgtm label, please assign sergeykanzhelev for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from tallclair March 27, 2026 16:18
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Mar 27, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: jpschmitt02 / name: Justin (77ac597)

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @jpschmitt02!

It looks like this is your first PR to kubernetes-sigs/node-readiness-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-readiness-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 27, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @jpschmitt02. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 27, 2026
@ajaysundark ajaysundark self-requested a review March 29, 2026 16:58
@ajaysundark
Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 29, 2026
@ajaysundark
Copy link
Copy Markdown
Contributor

/assign @ajaysundark

@jpschmitt02
Copy link
Copy Markdown
Author

/test

@jpschmitt02
Copy link
Copy Markdown
Author

/test all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Race condition in taint patching can clobber concurrent taint modifications

3 participants