Skip to content

Reserve specific taint key prefixes #177

Open
sats-23 wants to merge 1 commit intokubernetes-sigs:mainfrom
sats-23:issue3
Open

Reserve specific taint key prefixes #177
sats-23 wants to merge 1 commit intokubernetes-sigs:mainfrom
sats-23:issue3

Conversation

@sats-23
Copy link
Copy Markdown
Contributor

@sats-23 sats-23 commented Mar 23, 2026

Description

  1. Reserved taint key prefixes for:
  • readiness.k8s.io/system/*
  • readiness.k8s.io/core/*
  • readiness.k8s.io/node/*
  • readiness.k8s.io/device/*
  • readiness.k8s.io/network/*
  • readiness.k8s.io/storage/*
  1. Updated yaml examples and doc to reflect the same

Related Issue

Fixes #3

Type of Change

/kind feature

Testing

Checklist

  • make test passes
  • make lint passes

Does this PR introduce a user-facing change?

Reserved specific taint key prefixes (readiness.k8s.io/{system,core,node,device,network,storage}/*) for core operations.

Doc #(issue)

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 23, 2026

Deploy Preview for node-readiness-controller ready!

Name Link
🔨 Latest commit 540a938
🔍 Latest deploy log https://app.netlify.com/projects/node-readiness-controller/deploys/69c0fe508432880008bac1a6
😎 Deploy Preview https://deploy-preview-177--node-readiness-controller.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sats-23
Once this PR has been reviewed and has the lgtm label, please assign mrunalp for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 23, 2026
Signed-off-by: Sathvik <Sathvik.S@ibm.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 23, 2026
@sats-23 sats-23 marked this pull request as ready for review March 23, 2026 08:53
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define reserved taint prefix conventions for avoiding core conflicts

2 participants