Skip to content

E2E test fixes#98

Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
pravk03:test-fixes
Mar 20, 2026
Merged

E2E test fixes#98
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
pravk03:test-fixes

Conversation

@pravk03
Copy link
Copy Markdown
Contributor

@pravk03 pravk03 commented Mar 20, 2026

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2026
@k8s-ci-robot k8s-ci-robot requested review from ffromani and pohly March 20, 2026 00:37
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pravk03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 20, 2026
@catblade
Copy link
Copy Markdown
Contributor

Lgtm, but I'm not a licensed reviewer.

@pravk03 pravk03 marked this pull request as ready for review March 20, 2026 00:48
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2026
@k8s-ci-robot k8s-ci-robot requested a review from klueska March 20, 2026 00:48
Comment thread test/image/dracputester/app.go
@AutuSnow
Copy link
Copy Markdown
Contributor

/lgtm
The others seem fine. If you think there's no issue, you can cancel them
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2026
@AutuSnow
Copy link
Copy Markdown
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2026
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2026
@AutuSnow
Copy link
Copy Markdown
Contributor

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2026
@pravk03
Copy link
Copy Markdown
Contributor Author

pravk03 commented Mar 20, 2026

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2026
@k8s-ci-robot k8s-ci-robot merged commit 359bc3a into kubernetes-sigs:main Mar 20, 2026
7 checks passed
Copy link
Copy Markdown
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants