feat: add Helm chart for driver deployment by fmuyassarov · Pull Request #83 · kubernetes-sigs/dra-driver-cpu

fmuyassarov · 2026-03-11T22:31:29Z

Add a Helm chart for driver installation. This PR adds:

Helm chart for driver installation
Documentation to describe installation and available values
Linter CI for the charts & schema validation

Follow-up (TODO)

chart packaging and publishing to ghcr.io/kubernetes-sigs/dra-driver-cpu/charts/dra-driver-cpu
versioned releases from tags, 0.0.0-main from main branch

Note: currently all the templates (DeamonSet, ServiceAccount, etc are based on the what is available in install.yaml).

Fixes: #72

k8s-ci-robot · 2026-03-11T22:31:37Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fmuyassarov
Once this PR has been reviewed and has the lgtm label, please assign klueska for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fmuyassarov · 2026-03-12T16:53:14Z

I’ll keep this PR as a draft until we’re ready to land it (post 0.1.0?). In the meantime, please feel free to take a look and share any thoughts.
/cc @ffromani @pravk03

AutuSnow · 2026-03-13T02:00:28Z

@fmuyassarov Can you add the configurations for livenessProbe and readinessProbe

fmuyassarov · 2026-03-13T02:36:04Z

livenessProbe

Yes sure.

fmuyassarov · 2026-03-13T03:24:44Z

@fmuyassarov Can you add the configurations for livenessProbe and readinessProbe

@AutuSnow added #84 for the install.yaml and soon will add here as well.

AutuSnow · 2026-03-13T03:30:05Z

@fmuyassarov Can you add the configurations for livenessProbe and readinessProbe

@AutuSnow added #84 for the install.yaml and soon will add here as well.

Thanks !!

fmuyassarov · 2026-03-22T10:58:12Z

Similar health probes as in #84 are added here to the chart.

ffromani · 2026-04-13T13:58:48Z

will review again shortly, thanks for the patience

fmuyassarov · 2026-04-13T14:37:30Z

Thanks. But I would ask don't do it yet, because I'm about to add few more improvements in an hour or two. Will ping you once ready.

fmuyassarov · 2026-04-13T18:12:13Z

Thanks. But I would ask don't do it yet, because I'm about to add few more improvements in an hour or two. Will ping you once ready.

@ffromani
This should be ready now. Added few more changes I had in mind.

fmuyassarov · 2026-04-13T18:13:42Z

+maintainers:
+  - name: johnbelamaric
+    url: https://github.com/johnbelamaric
+  - name: pohly
+    url: https://github.com/pohly
+  - name: klueska
+    url: https://github.com/klueska
+  - name: ffromani
+    url: https://github.com/ffromani
+  - name: pravk03
+    url: https://github.com/pravk03


I'm sure we need to update this list, but perhaps @pravk03 @ffromani can confirm. This was copy paste of the current OWNERS file.

fmuyassarov · 2026-04-15T06:22:35Z

/test pull-dra-driver-cpu-e2e-device-mode-grouped-arm64

fmuyassarov · 2026-04-15T14:49:03Z

/test pull-dra-driver-cpu-e2e-device-mode-grouped-arm64
/test pull-dra-driver-cpu-e2e-device-mode-individual-arm64

pravk03 · 2026-04-17T22:43:36Z

+
+image:
+  repository: us-central1-docker.pkg.dev/k8s-staging-images/dra-driver-cpu/dra-driver-cpu
+  tag: latest


Should this be a release version ?

It can be and it doesn't matter much here because eventually we will publish this chart as an OCI artifact same way as container image and during that release process we will have to patch the version to the same as the release version that we are about to cut. In other words, it will be part of the release process PR that I will submit as follow up once the chart lands on the main.

or to be exact, with image.tag empty values.yaml, the template falls back to .Chart.AppVersion, so the DaemonSet will use the same release version image.

pravk03 · 2026-04-17T22:56:21Z

Thanks for looking into this! I've left a few minor comments inline. I have very limited experience with Helm, so I will lean on @ffromani and @AutuSnow who are already reviewing this PR for a more thorough review and approval.

AutuSnow

Thank you for your patience and contribution. I left a comment

AutuSnow · 2026-04-20T10:48:11Z

+spec:
+  selectors:
+    - cel:
+        expression: device.driver == "dra.cpu"


DeviceClass/dra.cpu is cluster-scoped and shared across any installation. helm uninstall will delete it, breaking other deployments or existing ResourceClaims that reference it.

It it true that uninstalling the chart will delete shared DeviceClass but how is it different from install.yaml? I mean that it's not a Helm specific problem but rather an inherent characteristic of how this driver works. This is the same behavior as kubectl delete -f install.yaml.

Agree it mirrors install.yaml behavior. But Helm gives us a tool install.yaml doesn't — helm.sh/resource-policy: keep on the DeviceClass would prevent accidental deletion on helm uninstall while preserving create/upgrade semantics. Worth considering since DeviceClass is cluster-scoped shared state. Not a blocker if you prefer to defer.

That's interesting, thanks for sharing. I wasn't aware of helm.sh/resource-policy: keep annotation. The only thing I'm unsure about is - once this annotation is set, the resources becomes orphaned (according to this document) and in case of a helm upgrade we won't be to replace the resource (when needed).

Are we okay with that?

AutuSnow · 2026-04-20T10:49:57Z

+spec:
+  selector:
+    matchLabels:
+      {{- include "dra-driver-cpu.selectorLabels" . | nindent 6 }}


install.yaml selector is app: dracpu; this chart uses app.kubernetes.io/{name,instance}. DaemonSet selectors are immutable, so users cannot migrate from install.yaml → Helm in place. Either keep the legacy app: dracpu selector label for compat, or add an explicit migration note (delete+reinstall) to README.

I may be missing something, but I’m not entirely sure why users would need to migrate from install.yaml to Helm. From our perspective, the installation method shouldn’t impact ongoing usage, and we are not expecting/requiring existing users to migrate and I don't see value in doing so.

Those who originally installed the driver using install.yaml can continue running it as is without any changes. For new installations users can choose between install.yaml and Helm, though Helm would generally be the preferred option. Could you help to clarify your question?

fmuyassarov · 2026-04-20T13:39:59Z

Thanks for the reviews @AutuSnow , @pravk03. I've addressed most of the comments. PTAL.

Alternative to install.yaml with a Helm chart that exposes driver configuration as values.yaml parameters. Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@est.tech>

Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@est.tech>

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2026

k8s-ci-robot requested a review from johnbelamaric March 11, 2026 22:31

k8s-ci-robot requested a review from klueska March 11, 2026 22:31

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 11, 2026

fmuyassarov force-pushed the devel/helm-charts branch 2 times, most recently from 9598847 to 3ba52b2 Compare March 12, 2026 16:47

k8s-ci-robot requested review from ffromani and pravk03 March 12, 2026 16:53

fmuyassarov mentioned this pull request Mar 19, 2026

Remove the init container used for NRI enablement #94

Open

fmuyassarov force-pushed the devel/helm-charts branch 2 times, most recently from d6efb7b to cbb81c8 Compare March 22, 2026 10:57

fmuyassarov marked this pull request as ready for review March 22, 2026 10:59

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 22, 2026

fmuyassarov mentioned this pull request Mar 22, 2026

PLANNING: Release 0.2.0 #57

Open

fmuyassarov force-pushed the devel/helm-charts branch from cbb81c8 to ae5cb15 Compare April 13, 2026 18:08

fmuyassarov commented Apr 13, 2026

View reviewed changes

fmuyassarov mentioned this pull request Apr 16, 2026

manifests: use stable image instead of staging #122

Merged

fmuyassarov mentioned this pull request Apr 17, 2026

chore: drop the initContainer #126

Open

pravk03 reviewed Apr 17, 2026

View reviewed changes

AutuSnow reviewed Apr 20, 2026

View reviewed changes

fmuyassarov force-pushed the devel/helm-charts branch from ae5cb15 to 2128016 Compare April 20, 2026 13:31

fmuyassarov added 4 commits April 21, 2026 00:35

feat: add Helm chart for configurable driver deployment

13c1411

Alternative to install.yaml with a Helm chart that exposes driver configuration as values.yaml parameters. Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@est.tech>

docs: add Helm chart README

d09677e

Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@est.tech>

ci: add Helm chart linting workflow

92f8054

Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@est.tech>

add JSON schema validation

288396a

Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@est.tech>

fmuyassarov force-pushed the devel/helm-charts branch from 2128016 to 288396a Compare April 20, 2026 21:35

Conversation

fmuyassarov commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Mar 11, 2026

Uh oh!

fmuyassarov commented Mar 12, 2026

Uh oh!

AutuSnow commented Mar 13, 2026

Uh oh!

fmuyassarov commented Mar 13, 2026

Uh oh!

fmuyassarov commented Mar 13, 2026

Uh oh!

AutuSnow commented Mar 13, 2026

Uh oh!

fmuyassarov commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ffromani commented Apr 13, 2026

Uh oh!

fmuyassarov commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fmuyassarov commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmuyassarov commented Apr 15, 2026

Uh oh!

fmuyassarov commented Apr 15, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pravk03 commented Apr 17, 2026

Uh oh!

AutuSnow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fmuyassarov commented Apr 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fmuyassarov commented Mar 11, 2026 •

edited

Loading

fmuyassarov commented Mar 22, 2026 •

edited

Loading

fmuyassarov commented Apr 13, 2026 •

edited

Loading

fmuyassarov commented Apr 13, 2026 •

edited

Loading