Refactor CPU Topology Representation for Asymmetric/Heterogeneous Systems#59
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AutuSnow The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
2b0f858 to
f16a624
Compare
|
This PR changes the cpumanager code we imported. At glance the changes seems sensible, but I need to careful review. So, the first question here is: is it time already to drift from the cpumanager reference code we imported? |
|
|
@AutuSnow: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cc @ffromani I would like to hear your thoughts. Is it necessary to continue waiting for the current PR |
|
/close |
|
@AutuSnow: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Refactor CPU topology representation to eliminate symmetric/uniform assumptions in CPU allocation logic, as discussed in #16 (comment).
Motivation
The previous CPUTopology methods (CPUsPerCore, CPUsPerSocket, CPUsPerUncore) computed global averages via simple division (e.g., NumCPUs / NumCores). This is incorrect when CPUsare offlined asymmetrically or on heterogeneous systems — all the math goes haywire as
Not fully resolved: