tests: add a test to validate pause and resume feature by darthsuburbus · Pull Request #351 · kubernetes-sigs/agent-sandbox

darthsuburbus · 2026-02-27T05:11:56Z

Description

Fixes #248
Add a e2e test that tests out the pause and resume functionality implemented in #82:

Create a Pod with a PVC and some generated data.
Scale the replicas to 0, controller should delete the pod associated with the sandbox.
Sandbox CR should remain consistent.
Scale the replicas to 1, the controller will recreate the pod. Verify that the data is intact on the PVC.

This test addresses the request made in #248.

Testing Done

   pvc_persistence_test.go:68: WaitForObjectNotFound *v1.Namespace (/pvc-persistence-test-1772168327331581080) took 43.463444028s
--- PASS: TestPVCPersistenceAcrossReplicas (89.90s)

k8s-ci-robot · 2026-02-27T05:12:03Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: darthsuburbus
Once this PR has been reviewed and has the lgtm label, please assign janetkuo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2026-02-27T05:12:05Z

Welcome @darthsuburbus!

It looks like this is your first PR to kubernetes-sigs/agent-sandbox 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/agent-sandbox has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2026-02-27T05:12:06Z

Hi @darthsuburbus. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

netlify · 2026-02-27T05:12:31Z

✅ Deploy Preview for agent-sandbox canceled.

Name	Link
🔨 Latest commit	`6078e62`
🔍 Latest deploy log	https://app.netlify.com/projects/agent-sandbox/deploys/69a6cf9929ebfa0008a69767

test/e2e/pvc_persistence_test.go

vicentefb

Thanks! This is a very valuable test that was missing. Overall, the logic is very solid. You're correctly simulating the exact behavior the controller executes when Replicas hits 0 (where it deletes the pod but retains the Sandbox CR and PVCs ), and then successfully validating the recovery. Left some comments.

darthsuburbus · 2026-03-03T12:27:49Z

Thanks! This is a very valuable test that was missing. Overall, the logic is very solid. You're correctly simulating the exact behavior the controller executes when Replicas hits 0 (where it deletes the pod but retains the Sandbox CR and PVCs ), and then successfully validating the recovery. Left some comments.

Thanks for the thoughtful feedback, I've addressed all comments. I can squash the commits before merging but keeping them for ease of review for now.

natasha41575 · 2026-03-04T16:43:39Z

test/e2e/pvc_persistence_test.go

@@ -0,0 +1,295 @@
+// Copyright 2026 The Kubernetes Authors.


we've stopped putting the dates on newly created files

Suggested change

// Copyright 2026 The Kubernetes Authors.

// Copyright The Kubernetes Authors.

(at least this is true in k/k... if this change results in a failure here you can feel free to disregard this comment)

natasha41575 · 2026-03-04T16:45:49Z

test/e2e/framework/predicates/sandbox.go

 	}
 	opts := []cmp.Option{
-		cmpopts.IgnoreFields(metav1.Condition{}, "LastTransitionTime"),
+		cmpopts.IgnoreFields(metav1.Condition{}, "LastTransitionTime", "Message", "ObservedGeneration"),


why ignore observedGeneration? Seems that it may be a useful thing to check?

natasha41575 · 2026-03-04T16:47:51Z

test/e2e/pvc_persistence_test.go

+
+	// Namespace
+	ns := &corev1.Namespace{}
+	ns.Name = fmt.Sprintf("pvc-persistence-test-%d", time.Now().UnixNano())


to make this easier to read, can we combine this with L64; just set the value when creating the object struct?

natasha41575 · 2026-03-04T16:48:09Z

test/e2e/pvc_persistence_test.go

+	pvcName := fmt.Sprintf("%s-%s", workspacesPVCTemplateName, pvcSandboxName)
+	pvc := &corev1.PersistentVolumeClaim{}
+	pvc.Name = pvcName
+	pvc.Namespace = ns.Name


same here; set these values in the object struct directly?

natasha41575 · 2026-03-04T16:48:18Z

test/e2e/pvc_persistence_test.go

+	pod := &corev1.Pod{}
+	pod.Name = pvcSandboxName
+	pod.Namespace = ns.Name


k8s-ci-robot · 2026-03-06T00:41:40Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot requested review from justinsb and soltysh February 27, 2026 05:12

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 27, 2026

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 27, 2026

janetkuo added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2026

vicentefb reviewed Feb 27, 2026

View reviewed changes

test/e2e/pvc_persistence_test.go Outdated Show resolved Hide resolved

vicentefb reviewed Feb 27, 2026

View reviewed changes

test/e2e/pvc_persistence_test.go Outdated Show resolved Hide resolved

vicentefb reviewed Feb 27, 2026

View reviewed changes

test/e2e/pvc_persistence_test.go Outdated Show resolved Hide resolved

vicentefb reviewed Feb 27, 2026

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2026

darthsuburbus added 2 commits March 3, 2026 04:04

add a test to validate pause and resume feature

a7bc74d

address review comments from vincentefb

7103823

darthsuburbus force-pushed the topic/as/pvc-pers-e2e branch from 8f8720b to 7103823 Compare March 3, 2026 12:08

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2026

fix go formatting issues

6078e62

darthsuburbus requested a review from vicentefb March 3, 2026 12:28

natasha41575 reviewed Mar 4, 2026

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2026

	// Copyright 2026 The Kubernetes Authors.
	// Copyright The Kubernetes Authors.

Conversation

darthsuburbus commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Feb 27, 2026

Uh oh!

k8s-ci-robot commented Feb 27, 2026

Uh oh!

k8s-ci-robot commented Feb 27, 2026

Uh oh!

netlify bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for agent-sandbox canceled.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vicentefb left a comment

Choose a reason for hiding this comment

Uh oh!

darthsuburbus commented Mar 3, 2026

Uh oh!

natasha41575 Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

natasha41575 Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

natasha41575 Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

natasha41575 Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

natasha41575 Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

darthsuburbus commented Feb 27, 2026 •

edited

Loading

netlify bot commented Feb 27, 2026 •

edited

Loading