feat: add GitHub Actions workflow linters by Aliexe-code · Pull Request #332 · kubernetes-sigs/agent-sandbox

Aliexe-code · 2026-02-20T03:49:12Z

Summary

Fixes #327
Adds GitHub Actions workflow validation using actionlint to catch errors before merging.

Changes

Add actionlint tool to validate workflow YAML files
Add dev/tools/lint-workflows script
Add dev/ci/presubmits/lint-workflows presubmit check
Add .github/workflows/ci.yml to run lint and tests on PRs
Add make lint-workflows target

netlify · 2026-02-20T03:49:20Z

✅ Deploy Preview for agent-sandbox canceled.

Name	Link
🔨 Latest commit	`c6f8933`
🔍 Latest deploy log	https://app.netlify.com/projects/agent-sandbox/deploys/69991689abb0080008af5cc6

linux-foundation-easycla · 2026-02-20T03:49:20Z

The committers listed above are authorized under a signed CLA.

✅ login: Aliexe-code / name: Ali Mohammed (3316b04, c420ee1, c6f8933)

k8s-ci-robot · 2026-02-20T03:49:21Z

Welcome @Aliexe-code!

It looks like this is your first PR to kubernetes-sigs/agent-sandbox 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/agent-sandbox has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2026-02-20T03:49:22Z

Hi @Aliexe-code. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

janetkuo · 2026-02-20T20:18:39Z

/ok-to-test

janetkuo · 2026-02-20T20:20:52Z

@Aliexe-code To fix the "The list of commits with invalid commit messages" error, you'll need to remove Fixes kubernetes-sigs#327 from your commit message.

janetkuo · 2026-02-20T20:26:05Z

.github/workflows/ci.yml

+          go-version-file: go.mod
+
+      - name: Run Unit Tests
+        run: ./dev/ci/presubmits/test-unit


All the presubmit tests in CI are running on prow, instead of being handled by GitHub Actions. Currently, all changes to .github/workflows are skipped in prow, ref kubernetes/test-infra#36482

Suggest using GitHub Action to trigger validation only on .github/workflows changes.
https://github.com/marketplace/actions/rhysd-actionlint might be a good tool to use here.
You'll only need to modify .github/workflows in this PR, and won't need to modify dev/ and Makefile.

k8s-ci-robot · 2026-02-21T00:02:06Z

@Aliexe-code: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
presubmit-agent-sandbox-e2e-test	`56331d2`	link	true	`/test presubmit-agent-sandbox-e2e-test`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

- Add CI workflow using rhysd/actionlint to validate workflow files - Triggers only on changes to .github/workflows/**

janetkuo · 2026-02-21T00:06:53Z

The test failure comes from this known flake: #326

janetkuo · 2026-02-21T00:42:33Z

.github/workflows/ci.yml

+      - uses: actions/checkout@v4
+
+      - name: Run actionlint
+        uses: rhysd/actionlint@v1


We should use devops-actions/actionlint@v0.1.10 wrapper from the Marketplace, to make using it easier. Please take a look at the user guide: https://github.com/marketplace/actions/rhysd-actionlint

janetkuo · 2026-02-21T01:47:45Z

.github/workflows/ci.yml

+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      pull-requests: write


For safety, let's keep the permission read-only (remove L12-14). We should be able to see error logs in the job runs, so we don't need to grant it permission to modify PRs. This change lgtm after this is fixed.

janetkuo

/lgtm

k8s-ci-robot · 2026-02-21T05:38:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Aliexe-code, janetkuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [janetkuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 20, 2026

k8s-ci-robot requested review from janetkuo and justinsb February 20, 2026 03:49

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 20, 2026

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 20, 2026

janetkuo reviewed Feb 20, 2026

View reviewed changes

Aliexe-code force-pushed the add-workflow-linters branch from 9802070 to 56331d2 Compare February 20, 2026 23:58

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 20, 2026

feat: add GitHub Actions workflow linters

c420ee1

- Add CI workflow using rhysd/actionlint to validate workflow files - Triggers only on changes to .github/workflows/**

Aliexe-code force-pushed the add-workflow-linters branch from 56331d2 to c420ee1 Compare February 21, 2026 00:07

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 21, 2026

janetkuo reviewed Feb 21, 2026

View reviewed changes

fix: use devops-actions/actionlint wrapper with proper permissions

3316b04

janetkuo reviewed Feb 21, 2026

View reviewed changes

janetkuo self-assigned this Feb 21, 2026

fix: remove pull-requests write permission for safety

c6f8933

janetkuo approved these changes Feb 21, 2026

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2026

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2026

k8s-ci-robot merged commit 9b643db into kubernetes-sigs:main Feb 21, 2026
6 checks passed

Conversation

Aliexe-code commented Feb 20, 2026

Summary

Changes

Uh oh!

netlify bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for agent-sandbox canceled.

Uh oh!

linux-foundation-easycla bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Feb 20, 2026

Uh oh!

k8s-ci-robot commented Feb 20, 2026

Uh oh!

janetkuo commented Feb 20, 2026

Uh oh!

janetkuo commented Feb 20, 2026

Uh oh!

janetkuo Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Feb 21, 2026

Uh oh!

janetkuo commented Feb 21, 2026

Uh oh!

janetkuo Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

janetkuo Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

janetkuo left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Feb 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Feb 20, 2026 •

edited

Loading

linux-foundation-easycla bot commented Feb 20, 2026 •

edited

Loading

janetkuo Feb 21, 2026 •

edited

Loading